New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete unused ProteinArraySignificanceTest endpoint with security issue #8751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this servlet is being removed, I think we also need to drop the servlet beans from portal/src/main/webapp/WEB-INF/web.xml (lines 341 - 348). Otherwise I expect we would see a BeanNotFound Exception during startup ... or maybe when the servlet is first accessed.
From the issue comments it seems like there is already approval to drop this service from the core. If that is so, this is a first step towards our larger cleanup (jettisoning the core).
|
If I may suggest. Keep the class. Make |
|
@adamabeshouse Why not just include the update to web.xml as Rob suggests? Seems like an easy update to the PR. |
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
2eb04a6
to
5bde0a8
Compare
|
@n1zea144 @sheridancbio done! thanks |
|
Kudos, SonarCloud Quality Gate passed! |
Fixes #8680