From 542e0f74609076b3304a513ea0cb9a6a29f5cac2 Mon Sep 17 00:00:00 2001 From: Luke Sikina Date: Wed, 15 Apr 2020 10:55:24 -0400 Subject: [PATCH] Untrim timeline when zoomed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a major revert of functionaility. We decided that trimming while zoomed in was not worth the zoom accuracy bugs we kept hitting. Instead, we are disabling trimming when zoomed in. This means reverting a swath of patches. We still kept the logic that determines the zoom region based on the data points inside it. This logic is slightly changed to use the timeline time of the data points rather than the pixel position. This commit also includes the other improvements added during the zoom process:   - Zoom extent covers the rulers   - Last lane of timeline doesn't collide with edge if tracks disabled   - y/m/d notation for ruler   - Single click zooming --- index.html | 44 ++++---- js/clinicalTimeline.js | 223 ++++++++----------------------------- js/plugins/overviewAxis.js | 14 +-- js/plugins/trimTimeline.js | 131 ++-------------------- js/plugins/zoom.js | 196 +++++++++++--------------------- 5 files changed, 144 insertions(+), 464 deletions(-) diff --git a/index.html b/index.html index dd0ac84..c642830 100644 --- a/index.html +++ b/index.html @@ -1,10 +1,10 @@ - + - + - - + + @@ -43,8 +43,8 @@ - - + +