Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in ResultListFragment #81

Closed
caarmen opened this issue May 24, 2017 · 4 comments

Comments

@caarmen
Copy link
Owner

commented May 24, 2017

Fewer crashes, only Marshmallow:

Caused by: java.lang.NullPointerException: 
  at ca.rmen.android.poetassistant.main.dictionaries.ResultListFragment.query(ResultListFragment.java:142)
  at ca.rmen.android.poetassistant.main.dictionaries.search.Search.search(Search.java:89)
  at ca.rmen.android.poetassistant.main.MainActivity.onNewIntent(MainActivity.java:6196)
  at android.app.Instrumentation.callActivityOnNewIntent(Instrumentation.java:1219)

More crashes, mostly Marshmallow:

java.lang.NullPointerException: 
  at ca.rmen.android.poetassistant.main.dictionaries.ResultListFragment.query(ResultListFragment.java:142)
  at ca.rmen.android.poetassistant.main.dictionaries.search.Search.lambda$-ca_rmen_android_poetassistant_main_dictionaries_search_Search_lambda$1(Search.java:104)
  at ca.rmen.android.poetassistant.main.dictionaries.search.-$Lambda$32.$m$0(Unknown Source:0)
  at ca.rmen.android.poetassistant.main.dictionaries.search.-$Lambda$32.run(Unknown Source:0)
  at android.os.Handler.handleCallback(Handler.java:733)

More crashes, mostly 4.4:

java.lang.NullPointerException: 
  at ca.rmen.android.poetassistant.main.dictionaries.ResultListHeaderFragment.setHeader(ResultListHeaderFragment.java:86)
  at ca.rmen.android.poetassistant.main.dictionaries.ResultListFragment.query(ResultListFragment.java:142)
  at ca.rmen.android.poetassistant.main.dictionaries.search.Search.lambda$-ca_rmen_android_poetassistant_main_dictionaries_search_Search_lambda$1(Search.java:104)
  at ca.rmen.android.poetassistant.main.dictionaries.search.-$Lambda$32.$m$0(Unknown Source:0)
  at ca.rmen.android.poetassistant.main.dictionaries.search.-$Lambda$32.run(Unknown Source:0)
  at android.os.Handler.handleCallback(Handler.java:743)

Code:

    public void query(String query) {
        Log.d(TAG, mTab + ": query() called with: " + "query = [" + query + "]");
        mHeaderFragment.setHeader(query);
        mHeaderFragment.setFilter(null);

mHeaderFragment is null or ResultListHeaderFragment.mBinding is null.

@caarmen caarmen added the bug label May 24, 2017

@caarmen

This comment has been minimized.

Copy link
Owner Author

commented May 26, 2017

Steps to reproduce:

  • Menu->Settings-> change theme
  • adb -e shell am start -a android.intent.action.VIEW -d poetassistant://thesaurus/hello

OR:

  • Menu->Settings->change theme
  • Switch to another app, select text, and choose "Thesaurus"
@caarmen

This comment has been minimized.

Copy link
Owner Author

commented May 26, 2017

Related to #19

caarmen added a commit that referenced this issue May 26, 2017

caarmen added a commit that referenced this issue May 26, 2017

caarmen added a commit that referenced this issue May 26, 2017

@caarmen caarmen closed this May 26, 2017

@caarmen

This comment has been minimized.

Copy link
Owner Author

commented Jun 1, 2017

Still happens in 1.18.2:

java.lang.NullPointerException: 
  at ca.rmen.android.poetassistant.main.dictionaries.ResultListFragment.query(ResultListFragment.java:145)
  at ca.rmen.android.poetassistant.main.dictionaries.search.Search.lambda$search$0(Search.java:87)
  at ca.rmen.android.poetassistant.main.dictionaries.search.Search$$Lambda$1.run(Unknown Source:0)
  at android.os.Handler.handleCallback(Handler.java:739)
  at android.os.Handler.dispatchMessage(Handler.java:95)
  at android.os.Looper.loop(Looper.java:148)
  at android.app.ActivityThread.main(ActivityThread.java:7325)
  at java.lang.reflect.Method.invoke(Native Method:0)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

@caarmen caarmen reopened this Jun 1, 2017

caarmen added a commit that referenced this issue Jun 1, 2017

@caarmen caarmen referenced this issue Jun 1, 2017

caarmen added a commit that referenced this issue Jun 1, 2017

@caarmen

This comment has been minimized.

Copy link
Owner Author

commented Jun 1, 2017

Maybe fixed in 1.18.3...

@caarmen caarmen closed this Jun 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.