Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My comments on the mod checker output #92

Open
SomeTroglodyte opened this issue Apr 13, 2024 · 1 comment
Open

My comments on the mod checker output #92

SomeTroglodyte opened this issue Apr 13, 2024 · 1 comment

Comments

@SomeTroglodyte
Copy link

Small problems:

  • Four deprecations - just do what they say (and I have no idea why <upon discovering [Military Science]> was replaced by <upon discovering [Military Science] technology>)
  • The Coffee Axis building has uniques whose actual effect are on the tile improvement. Use the Comment UniqueType:
	"uniques": [
        	"Creates a [Coffee Hacienda] improvement on a specific tile",
		"Comment [+1 Coffee from Coffee Hacienda]",
		"[+1 Production, +1 Culture, +1 Gold] from [Coffee Hacienda] tiles [in this city]",
		"Comment [The Hacienda cannot be built on Desert, Tundra nor Snow, only on Grassland/Plains Hills]",
		"Limited to [4] per Civilization",
        	"Destroyed when the city is captured",
        	"Unsellable"
        ],
  • If you're really happy with the Nation colors, just add "Suppress warning [*colors do not contrast enough*]" to the modOptions uniques.

Medium problems:

  • Darien Gap as tile improvement can't do damage or extra movement. No field or unique allows this. And IMHO - it is a terrain feature by character and story, and Unciv Terrain(type=Feature) can do both.

  • Cuba's "Receive a free Social Policy each time you complete a Factory, Public School or Hospital in the capital" is done as 3 hidden Buildings - Trade unions, Free education, Free healthcare, right? Well, I can't imagine that works cleanly. Extra turn, depends on user having autoselect construction on,...? Haven't tested. But why not as Nation Unique (instead of those Buildings)?

        "uniques": [
            "Comment [Receive a free Social Policy each time you complete a Factory, Public School or Hospital in the capital]",
            "Free Social Policy <upon constructing [Factory] [in capital]> <hidden from users>",
            "Free Social Policy <upon constructing [Public School] [in capital]> <hidden from users>",
            "Free Social Policy <upon constructing [Hospital] [in capital]> <hidden from users>",
        ],
@RealBamboolord
Copy link

* Cuba's "Receive a free Social Policy each time you complete a Factory, Public School or Hospital in the capital" is done as 3 hidden Buildings - Trade unions, Free education, Free healthcare, right? Well, I can't imagine that works cleanly. Extra turn, depends on user having autoselect construction on,...? Haven't tested. But why not as Nation Unique (instead of those Buildings)?
        "uniques": [
            "Comment [Receive a free Social Policy each time you complete a Factory, Public School or Hospital in the capital]",
            "Free Social Policy <upon constructing [Factory] [in capital]> <hidden from users>",
            "Free Social Policy <upon constructing [Public School] [in capital]> <hidden from users>",
            "Free Social Policy <upon constructing [Hospital] [in capital]> <hidden from users>",
        ],

This is to prevent exploits done by selling Factories and building them again Iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants