Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split BR.md into sections #27

Closed
jsha opened this issue Jul 5, 2016 · 6 comments
Closed

Split BR.md into sections #27

jsha opened this issue Jul 5, 2016 · 6 comments
Labels
baseline-requirements Server Certificate CWG - Baseline Requirements

Comments

@jsha
Copy link
Contributor

jsha commented Jul 5, 2016

BR.md seems to be large enough that GitHub's rich diff generator takes close to 5 seconds, which is their internal timeout per discussions with GitHub Support. That means viewing the rich diff sometimes produces a timeout, for example at https://github.com/cabforum/documents/pull/24/files.

It sounds like GitHub won't change the timeout, and the code is not open source so we don't have the option of optimizing it.

I'd like to split up BR.md into multiple files, one per section, and recombine them at build time. That will probably make the rich diff generator finish safely below the timeout.

Any objections? @pzb?

@pzb
Copy link
Contributor

pzb commented Jul 5, 2016

Sounds good to me. However we need to figure out how to handle in-progress ballots; several branches will need re-doing.

@sleevi
Copy link
Contributor

sleevi commented Jul 5, 2016

My experiences in W3C and IETF suggest that, while understandably well-motivated, such actions generally make the document significantly harder to manage and keep consistent @jsha . Further, I think that's the sort of change that might be better discussed in the Forum at large as part of workflow.

It seems like you're making more work for people who want to contribute. Is there a way to avoid that?

@jsha
Copy link
Contributor Author

jsha commented Jul 6, 2016

Good point about making it harder to contribute: People would need to find the correct section to edit. I'm definitely interested in finding alternate approaches that make it possible to continue to read rich diffs (which many Forum members find useful) while also using a single doc. If there's a third-party tool to generate rich diffs, we could run it automatically from Travis and link to it from pull requests.

Will cross-post on cabfpub, thanks for the reminder.

@sleevi sleevi added servercert-wg baseline-requirements Server Certificate CWG - Baseline Requirements labels Jun 18, 2020
@sleevi
Copy link
Contributor

sleevi commented Dec 10, 2020

@jsha Wanting to circle back on this, now that some of the infrastructure is landing / has landed.

Where we currently stand is:

  • Some of the documents rely on Pandoc-flavored-markdown / Pandoc extensions to get a good universal format, that don't render well in GitHub-Flavored Markdown
    • There is a Pandoc -> GFM converter, but haven't run our docs through this
  • We've tentatively got redline support (once I land Add support for generating redline diffs build-guidelines-action#1 and get integrated), which offers a rich PDF redline, at least.
    • I'm sad this is not HTML like the GitHub diff is, but I do hope perhaps over the holidays some progress will be made on an HTML render
  • The tooling right now doesn't use Pandoc's multi-markdown input (where it concats files together before converting), so this would require some tooling updates
    • However, it does support validating cross-references

I'm curious how you feel about continuing this? I'm mixed, and can see pros and cons, but curious to get the current thinking.

@jsha
Copy link
Contributor Author

jsha commented Dec 10, 2020

It sounds like the redline support in cabforum/build-guidelines-action#1 is a good alternate. I'm happy to go with that and drop the idea of splitting into sections.

@ryancdickson
Copy link
Contributor

@barrini - Seems like this issue can be closed.

@barrini barrini closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baseline-requirements Server Certificate CWG - Baseline Requirements
Projects
None yet
Development

No branches or pull requests

5 participants