Handle sprintf() appending a NUL byte [issues 53 and 54] #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sprintf() always appends a NUL byte to whatever it writes to the destination string.
If the image dimensions are 0x0, then no image data is written and space is allocated only for the headers in export_tga() and export_tiff(). This will lead to a buffer overflow when the last byte(s) of this header are written to using sprintf().
So, in export_tga() put the data into the buffer using plain pointer operations (*ptr++ = ...),
in export_tiff() allocate one additional byte for the NUL byte.