New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why cache name can't contain characher:'#'? #65

Closed
ChiZelin opened this Issue Jul 5, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@ChiZelin

ChiZelin commented Jul 5, 2017

Excuse me, could you please tell me that,when you design the Cache2k,why not allow cache name contains characher : '#' ? What's the advantage of doing this?

Thank you!

@cruftex

This comment has been minimized.

Member

cruftex commented Jul 6, 2017

Hi Leon!

The main reason character are restricted, is the use in the JMX object name. Although a '#' is allowed in an object name, I decided to be more restrictive and don't allow any special characters in URLs. This way I hope not to get into trouble for future extensions when a cache name may be used in a file name, for example.

Why you want to use '#'? Is there any standard/convention/product that needs it?

@ChiZelin

This comment has been minimized.

ChiZelin commented Jul 7, 2017

Hi Jens!

Thank you for your reply.

I try to use cache2k in a project, the project has identified the cache name and the cache name contains "#".

@cruftex

This comment has been minimized.

Member

cruftex commented Jul 7, 2017

I am revisiting what characters we can allow. The JMX tests are passing, when using a '#'.

@ChiZelin

This comment has been minimized.

ChiZelin commented Jul 10, 2017

OK,Thanks.

@cruftex cruftex added this to the v1 milestone Jul 10, 2017

@cruftex

This comment has been minimized.

Member

cruftex commented Jul 11, 2017

The following characters will be additionally allowed +!'%#
Will be released in 1.0.0.Final.

@cruftex cruftex closed this Jul 11, 2017

@cruftex

This comment has been minimized.

Member

cruftex commented Jul 11, 2017

The release 1.0.0.Final is now available.

@ChiZelin

This comment has been minimized.

ChiZelin commented Jul 12, 2017

OK,thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment