From acaafc5d2504d0bce3b2dadbe71836ae62b42e92 Mon Sep 17 00:00:00 2001
From: Brian Love <brian@liveloveapp.com>
Date: Tue, 12 May 2026 09:24:55 -0700
Subject: [PATCH] =?UTF-8?q?fix(chat):=20post-merge=20sidenav=20polish=20?=
 =?UTF-8?q?=E2=80=94=20semantic=20<nav>=20+=20rename=20palette=20output?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- chat-sidenav: replace <aside role="navigation"> with semantic <nav>
  (adds tabindex="-1" so Esc keydown still binds without tripping the
  interactive-supports-focus lint rule).
- chat-history-search-palette: rename close output to closed, dropping
  the @angular-eslint/no-output-native suppression. Past-tense matches
  the convention of state outputs (opened/closed).
- examples-chat-angular: switch the consumer binding to (closed).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 apps/website/content/docs/chat/api/api-docs.json         | 2 +-
 .../chat/angular/src/app/shell/demo-shell.component.html | 2 +-
 .../compositions/chat-sidenav/chat-sidenav.component.ts  | 6 +++---
 .../chat-history-search-palette.component.spec.ts        | 4 ++--
 .../chat-history-search-palette.component.ts             | 9 ++++-----
 5 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/apps/website/content/docs/chat/api/api-docs.json b/apps/website/content/docs/chat/api/api-docs.json
index 91aa630a..dd148174 100644
--- a/apps/website/content/docs/chat/api/api-docs.json
+++ b/apps/website/content/docs/chat/api/api-docs.json
@@ -2369,7 +2369,7 @@
         "optional": false
       },
       {
-        "name": "close",
+        "name": "closed",
         "type": "OutputEmitterRef<void>",
         "description": "",
         "optional": false
diff --git a/examples/chat/angular/src/app/shell/demo-shell.component.html b/examples/chat/angular/src/app/shell/demo-shell.component.html
index 74a2c8a7..9d58c818 100644
--- a/examples/chat/angular/src/app/shell/demo-shell.component.html
+++ b/examples/chat/angular/src/app/shell/demo-shell.component.html
@@ -40,7 +40,7 @@
     [(query)]="searchQuery"
     [results]="searchResults()"
     (threadSelected)="onSearchSelect($event)"
-    (close)="paletteOpen.set(false)"
+    (closed)="paletteOpen.set(false)"
   />
 
   <chat-debug
diff --git a/libs/chat/src/lib/compositions/chat-sidenav/chat-sidenav.component.ts b/libs/chat/src/lib/compositions/chat-sidenav/chat-sidenav.component.ts
index 860d78c6..609369d1 100644
--- a/libs/chat/src/lib/compositions/chat-sidenav/chat-sidenav.component.ts
+++ b/libs/chat/src/lib/compositions/chat-sidenav/chat-sidenav.component.ts
@@ -35,10 +35,10 @@ export type ChatSidenavMode = 'expanded' | 'collapsed' | 'drawer';
         (click)="openChange.emit(false)"
       ></button>
     }
-    <aside
+    <nav
       class="chat-sidenav"
-      role="navigation"
       aria-label="Sidebar navigation"
+      tabindex="-1"
       (keydown.escape)="onEscape()"
     >
       <div class="chat-sidenav__header">
@@ -96,7 +96,7 @@ export type ChatSidenavMode = 'expanded' | 'collapsed' | 'drawer';
       <div class="chat-sidenav__account">
         <ng-content select="[sidenavAccount]" />
       </div>
-    </aside>
+    </nav>
   `,
 })
 export class ChatSidenavComponent {
diff --git a/libs/chat/src/lib/primitives/chat-history-search-palette/chat-history-search-palette.component.spec.ts b/libs/chat/src/lib/primitives/chat-history-search-palette/chat-history-search-palette.component.spec.ts
index 57f8c638..221592c1 100644
--- a/libs/chat/src/lib/primitives/chat-history-search-palette/chat-history-search-palette.component.spec.ts
+++ b/libs/chat/src/lib/primitives/chat-history-search-palette/chat-history-search-palette.component.spec.ts
@@ -114,7 +114,7 @@ describe('ChatHistorySearchPaletteComponent', () => {
   it('Esc emits close', () => {
     const fixture = render();
     let emits = 0;
-    fixture.componentInstance.close.subscribe(() => emits++);
+    fixture.componentInstance.closed.subscribe(() => emits++);
     const input = fixture.nativeElement.querySelector('input') as HTMLInputElement;
     input.dispatchEvent(new KeyboardEvent('keydown', { key: 'Escape', bubbles: true }));
     expect(emits).toBe(1);
@@ -123,7 +123,7 @@ describe('ChatHistorySearchPaletteComponent', () => {
   it('Scrim click emits close', () => {
     const fixture = render();
     let emits = 0;
-    fixture.componentInstance.close.subscribe(() => emits++);
+    fixture.componentInstance.closed.subscribe(() => emits++);
     const scrim = fixture.nativeElement.querySelector('.chat-history-search-palette__scrim') as HTMLButtonElement;
     scrim.click();
     expect(emits).toBe(1);
diff --git a/libs/chat/src/lib/primitives/chat-history-search-palette/chat-history-search-palette.component.ts b/libs/chat/src/lib/primitives/chat-history-search-palette/chat-history-search-palette.component.ts
index 32de1fa1..052fecbe 100644
--- a/libs/chat/src/lib/primitives/chat-history-search-palette/chat-history-search-palette.component.ts
+++ b/libs/chat/src/lib/primitives/chat-history-search-palette/chat-history-search-palette.component.ts
@@ -34,7 +34,7 @@ let paletteInstanceCounter = 0;
         type="button"
         class="chat-history-search-palette__scrim"
         aria-label="Close search"
-        (click)="close.emit()"
+        (click)="closed.emit()"
       ></button>
       <div
         class="chat-history-search-palette"
@@ -64,7 +64,7 @@ let paletteInstanceCounter = 0;
             type="button"
             class="chat-history-search-palette__close"
             aria-label="Close"
-            (click)="close.emit()"
+            (click)="closed.emit()"
           >
             <svg width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true">
               <line x1="18" y1="6" x2="6" y2="18"/>
@@ -116,8 +116,7 @@ export class ChatHistorySearchPaletteComponent {
   readonly placeholder = input<string>('Search conversations');
 
   readonly threadSelected = output<string>();
-  // eslint-disable-next-line @angular-eslint/no-output-native
-  readonly close = output<void>();
+  readonly closed = output<void>();
 
   protected readonly activeIndex = signal<number>(0);
   protected readonly listId = `chat-history-search-palette__results-${++paletteInstanceCounter}`;
@@ -155,7 +154,7 @@ export class ChatHistorySearchPaletteComponent {
   protected onInputKeydown(e: KeyboardEvent): void {
     if (e.key === 'Escape') {
       e.preventDefault();
-      this.close.emit();
+      this.closed.emit();
       return;
     }
     if (e.key === 'ArrowDown') {