Getting NoMethodError after adding 'mongoid_includes' to Gemfile

[mityakoval]

Hello,

I'm getting NoMethodError: undefined method 'first' for false:FalseClass every time I query for any document. Once I remove this gem from the Gemfile everything works.

The whole stack:

NoMethodError: undefined method 'first' for false:FalseClass
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/mongoid-6.0.2/lib/mongoid/contextual/mongo.rb:271:in 'find_first'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/mongoid-6.0.2/lib/mongoid/contextual.rb:20:in 'find_first'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/mongoid-6.0.2/lib/mongoid/findable.rb:114:in 'find_by'
  from (irb):3
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/railties-5.0.0.1/lib/rails/commands/console.rb:65:in 'start'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/railties-5.0.0.1/lib/rails/commands/console_helper.rb:9:in 'start'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/railties-5.0.0.1/lib/rails/commands/commands_tasks.rb:78:in 'console'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/railties-5.0.0.1/lib/rails/commands/commands_tasks.rb:49:in 'run_command!'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/railties-5.0.0.1/lib/rails/commands.rb:18:in '<top (required)>'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/activesupport-5.0.0.1/lib/active_support/dependencies.rb:293:in 'require'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/activesupport-5.0.0.1/lib/active_support/dependencies.rb:293:in 'block in require'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/activesupport-5.0.0.1/lib/active_support/dependencies.rb:259:in 'load_dependency'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/activesupport-5.0.0.1/lib/active_support/dependencies.rb:293:in 'require'
  from /Users/mityakoval/RubymineProjects/vaktdagboka/bin/rails:9:in '<top (required)>'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/activesupport-5.0.0.1/lib/active_support/dependencies.rb:287:in 'load'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/activesupport-5.0.0.1/lib/active_support/dependencies.rb:287:in 'block in load'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/activesupport-5.0.0.1/lib/active_support/dependencies.rb:259:in 'load_dependency'
  from /Users/mityakoval/.rvm/gems/ruby-2.3.0@vaktboka/gems/activesupport-5.0.0.1/lib/active_support/dependencies.rb:287:in 'load'
  from /Users/mityakoval/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in 'require'
  from /Users/mityakoval/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in 'require'

[ElMassimo]

@mityakoval Haven't tested the gem with mongoid 6. If you make a PR to add mongoid 6 to the test matrix I can take a look at the failing tests 😃

[mityakoval]

Ah, okay. I just saw #3 as successfully closed and assumed it already supports mongoid 6. 😃

[ElMassimo]

Completely forgot about that PR 😅

I ran tests with 6.0.0, 6.0.1, and 6.0.2. Everything seems to be working correctly in 6.0.0, but from 6.0.1 going forward the same error you posted is happening in some of the scenarios.

I'm not able to take a look at this at the moment, but will happily accept any patch for what seems to be breaking changes in 6.0.1 😃

[ElMassimo]

Very likely that it's related to mongodb/mongoid#4326, since in order to get the job done we need to modify some of Mongoid's internals, since it's not designed with extensibility in mind.

[ElMassimo]

Related: https://jira.mongodb.org/browse/MONGOID-4370

[ElMassimo]

@mityakoval v2.0.0 is now available, thanks again for the bug report!

[mrpoundsign]

@ElMassimo We're also experiencing this with mongoid 5.2.0/mongoid_includes 1.1.3. Any chance of a backport to the 1.1 series?

[ElMassimo]

Happy to release a new version, but don't have time to check it until next week.

In the meantime, could you try forking master and changing the gemspec to downgrade the mongoid version (down to 5) and see if you still experience the error?

[mrpoundsign]

@ElMassimo The issue still exists with mongoid 5.1.6 and mongoid_includes 1.1.3. We cannot currently go back to mongoid 5.0