move all services in their prefix #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
force-pushed
the
services-prefix
branch
2 times, most recently
from
efd042c
to
22dc859
Compare
|
While it's early days, let's still use renaming hints so devenv users get a nice error with the help text to migrate over. Also seems that the tests fail because not everything was renamed |
zimbatm
force-pushed
the
services-prefix
branch
from
22dc859
to
c9548a6
Compare
|
Cool, I wanted to check if you would accept the PR before doing the extra work. |
zimbatm
force-pushed
the
services-prefix
branch
from
c9548a6
to
3b5aba1
Compare
|
@domenkozar do you think it's enough to alias the enable option? I'm hoping that the user gets the hint and adjusts the other options on their own. |
|
Sounds good! |
zimbatm
force-pushed
the
services-prefix
branch
from
3b5aba1
to
8f2716a
Compare
This makes it easier to find out which modules are to declare new processes. It also follows the convention set by NixOS that services should be prefixed with "services.".
zimbatm
force-pushed
the
services-prefix
branch
from
8f2716a
to
e430be7
Compare
|
Ok. Docs fixed, options aliased, examples fixed. Should be good to go. |
zimbatm
added a commit
to zimbatm/devenv
that referenced
this pull request
Dec 12, 2022
I missed one reference in cachix#200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to find out which modules are to declare new
processes. It also follows the convention set by NixOS that services
should be prefixed with "services.".