add golines pre-commit hook #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandydoo
approved these changes
Oct 10, 2024
sandydoo
requested changes
Oct 10, 2024
Member
sandydoo
left a comment
sandydoo
left a comment
There was a problem hiding this comment.
You have to import golines from pkgs and add it to tools. See tools.nix.
Contributor
Author
|
I have made the change, please let me know if I did it correctly? Thanks |
sandydoo
reviewed
Oct 16, 2024
| type = types.submodule { | ||
| imports = [ hookModule ]; | ||
| options.settings = { | ||
| flags = mkOption { |
Member
There was a problem hiding this comment.
For what it's worth, all hooks accept an args option that does this.
Contributor
Author
There was a problem hiding this comment.
ahh good to know for the next one thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to copy the gofmt and move it over to golines as the tooling is very similar.
https://github.com/segmentio/golines