bugfix: remove before/after options from config json file #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit to add ordering priority to the hooks introduced new keys into the pre-commit JSON config file. These keys should not be there are they are not keys pre-commit is aware of and produce warning messages. e.g.: ``` [WARNING] Unexpected key(s) present on local => treefmt: after, before ``` This commit fixes it by filter out all keys with names `before` or `after`, in Nix, before writing the configuration to file. Fixes cachix#112
Member
|
Thank you! |
sandydoo
added a commit
that referenced
this pull request
Dec 15, 2024
Consolidates previous work from #533 and #536. - Removes `before` and `after` from the `raw` config. These are not valid pre-commit configuration options and should not be here. - Removes code to filter out `before` and `after` from the `raw` config. There's nothing to filter out if they're not in the config in the first place. - Set `id` to the attr name of the hook, instead of the `name`. This corrects a mistake made in the module transition (#397). Technically, a breaking change, but we haven't had feedback from the initial mistake. - Expose `id` in options.
sandydoo
added a commit
that referenced
this pull request
Dec 15, 2024
Consolidates previous work from #533 and #536. - Removes `before` and `after` from the `raw` config. These are not valid pre-commit configuration options and should not be here. - Removes code to filter out `before` and `after` from the `raw` config. There's nothing to filter out if they're not in the config in the first place. - Set `id` to the attr name of the hook, instead of the `name`. This corrects a mistake made in the module transition (#397). Technically, a breaking change, but we haven't had feedback from the initial mistake. - Expose `id` in options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit to add ordering priority to the hooks introduced new keys into the pre-commit JSON config file. These keys should not be there are they are not keys pre-commit is aware of and produce warning messages. e.g.:
This commit fixes it by filter out all keys with names
beforeorafter, in Nix, before writing the configuration to file.Fixes #112