Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci #128

Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix ci #128

merged 1 commit into from
Mar 30, 2022

Conversation

domenkozar
Copy link
Member

No description provided.

@Artturin
Copy link
Contributor

Artturin commented Mar 30, 2022

https://github.com/NixOS/nix/blob/03be091e0acb97a6a0d65011ec9ac8d700ec9032/scripts/install-nix-from-closure.sh#L27-L37

/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/nix-binary-tarball-unpack.XXXXXXXXXX.T6x3SPBf/unpack/nix-2.3.5-x86_64-darwin/install: macOS 11.6.4 is not supported, upgrade to 10.12.6 or higher

weirdly the following works and prints worked

#!/usr/bin/env bash

IFS='.' read -r macos_major macos_minor macos_patch << EOF
11.6.4
EOF

#echo $macos_major $macos_minor $macos_patch

if [ "$macos_major" -lt 10 ] || { [ "$macos_major" -eq 10 ] && [ "$macos_minor" -lt 12 ]; } || { [ "$macos_minor" -eq 12 ] && [ "$macos_patch" -lt 6 ]; }; then
    echo "$0: macOS X is not supported, upgrade to 10.12.6 or higher"
    exit 1
else
    echo "worked"
fi

@domenkozar domenkozar merged commit 83e7d63 into master Mar 30, 2022
@domenkozar
Copy link
Member Author

https://github.com/NixOS/nix/blob/03be091e0acb97a6a0d65011ec9ac8d700ec9032/scripts/install-nix-from-closure.sh#L27-L37

/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/nix-binary-tarball-unpack.XXXXXXXXXX.T6x3SPBf/unpack/nix-2.3.5-x86_64-darwin/install: macOS 11.6.4 is not supported, upgrade to 10.12.6 or higher

weirdly the following works and prints worked

#!/usr/bin/env bash

IFS='.' read -r macos_major macos_minor macos_patch << EOF
11.6.4
EOF

#echo $macos_major $macos_minor $macos_patch

if [ "$macos_major" -lt 10 ] || { [ "$macos_major" -eq 10 ] && [ "$macos_minor" -lt 12 ]; } || { [ "$macos_minor" -eq 12 ] && [ "$macos_patch" -lt 6 ]; }; then
    echo "$0: macOS X is not supported, upgrade to 10.12.6 or higher"
    exit 1
else
    echo "worked"
fi

Do we need to fix the logic in the installer?

@Artturin
Copy link
Contributor

Artturin commented Mar 30, 2022

i investigated further and found out that 2.3.5 does not have the commit needed for sur support
NixOS/nix@14c7e77

the first version to have it is 2.3.8

the newest 2.3 maintenance release is 2.3.16
https://github.com/NixOS/nix/tree/2.3-maintenance

#133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants