Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing a CDEF item, changing the type switches from EDIT to CREATE #1210

Closed
netniV opened this issue Jan 15, 2018 · 3 comments
Closed

Comments

@netniV
Copy link
Member

netniV commented Jan 15, 2018

If you are editing a CDEF, and use the wrong order of items, you are unable to simply correct the issue by changing the types whilst editing an item as it switches to create mode (button also changes from save to create).

Eg, you create a CDEF,

  1. Special Data Source, Current
  2. Operator *
  3. String 8

Then realise, actually 2 and 3 are the wrong way around, so you click on Item 2 and try to change that to String, but it now creates a new item and if you aren't paying attention you end up with

  1. Special Data Source, Current
  2. Operator *
  3. String 8
  4. String 8
@netniV
Copy link
Member Author

netniV commented Jan 15, 2018

Just to verify, this problem still exists after reverting to 1.1.30 from 1.1.21 :)

cigamit added a commit that referenced this issue Jan 15, 2018
Modifying CDEF and VDEF items results in a new item being added.
@cigamit
Copy link
Member

cigamit commented Jan 15, 2018

Oh my, that's some old code that slipped through the cracks. Both CDEF and VDEF were based upon each other, so I reviewed the VDEF code and found the same issue. There was some i18n missing too. Ugly stuff. Need to open a new bug since this interface does not use the form API and therefore will not work well on a mobile device.

@cigamit cigamit closed this as completed Jan 15, 2018
@cigamit
Copy link
Member

cigamit commented Jan 15, 2018

Logged #1211 to cover this change.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants