Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When switching an Automation Tree Rule's leaf type, remove invalid Automation Rule Items #1350

Closed
netniV opened this issue Feb 14, 2018 · 2 comments
Closed

When switching an Automation Tree Rule's leaf type, remove invalid Automation Rule Items #1350

netniV opened this issue Feb 14, 2018 · 2 comments
Labels
automation Automation related issue enhancement General tag for an enhancement resolved A fixed issue
Milestone
Cacti 1.2.0

Comments

@netniV
Copy link
Member

netniV commented Feb 14, 2018

When switching the leaf type from Graph to Host, rule items can still contain non-host field names resulting in invalid SQL.
@cigamit
Copy link
Member

cigamit commented Feb 15, 2018

1.2

@cigamit cigamit added this to the Cacti Release 1.2 milestone Feb 15, 2018
@cigamit cigamit added automation Automation related issue enhancement General tag for an enhancement labels Feb 15, 2018
@netniV netniV changed the title Autom8 Tree Rules - Switching Leaf Type Issue When switching an Automation Tree Rule's leaf type, remove invalid Automation Rule Items Jul 26, 2018
netniV added a commit to netniV/cacti that referenced this issue Jul 26, 2018
@netniV
Resolving Issue#1350
d8190e0 
As per Cacti#1350, when switching an Automation Tree Rule's leaf type, remove invalid Automation Rule Items (Object Selection and Tree Creation criteria)
@netniV netniV mentioned this issue Jul 26, 2018
Merged
cigamit pushed a commit that referenced this issue Jul 26, 2018
@netniV @cigamit
Resolving Issue #1350 (#1753)
8ea17f0 
* Ensure previously selected field isn't wiped when ediing automation rule item

* Resolving Issue#1350

As per #1350, when switching an Automation Tree Rule's leaf type, remove invalid Automation Rule Items (Object Selection and Tree Creation criteria)
@netniV
Copy link
Member Author

netniV commented Jul 26, 2018

This has now been merged.

@netniV netniV closed this as completed Jul 26, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
@TheWitness TheWitness added the resolved A fixed issue label Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
automation Automation related issue enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Milestone
Cacti 1.2.0
Development

No branches or pull requests
3 participants
@cigamit @TheWitness @netniV