Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify Admins that page errors exist even when using dynamic callbacks #1392

Closed
netniV opened this issue Feb 23, 2018 · 5 comments
Closed

Notify Admins that page errors exist even when using dynamic callbacks #1392

netniV opened this issue Feb 23, 2018 · 5 comments
Labels
enhancement General tag for an enhancement plugins Plugin related issue resolved A fixed issue
Milestone

Comments

@netniV
Copy link
Member

netniV commented Feb 23, 2018

If a plugin is clicked on, an AJAX error is correctly handled if error 500 occurs. However, the plugin itself is not disabled and there is no evidence of the error 500 in the Cacti log since it occurs before Cacti can even start.

Have a simple API page to receive a single name of the plugin to disable (with validation code?) which can be called without checking the status from the jQuery HTTP error handler if /plugins/ is detected in the url.

@cigamit cigamit added enhancement General tag for an enhancement gui UI related issue labels Feb 24, 2018
@cigamit cigamit added this to the Cacti Release 1.2 milestone Feb 24, 2018
@cigamit
Copy link
Member

cigamit commented Feb 24, 2018

I thought about this one, and for a minute, I thought to myself, who cares it's the GUI. It's going to be tricky though. We may never know which plugin per se as plugins can inject code just about anywhere.

@netniV
Copy link
Member Author

netniV commented Feb 24, 2018

That is quite true. Unless there is a backtrace in the output.

@cigamit cigamit removed the gui UI related issue label Mar 4, 2018
@netniV netniV modified the milestones: Cacti 1.2, Cacti 1.3 Jul 24, 2018
@netniV netniV added plugins Plugin related issue and removed plugins Plugin related issue labels Feb 21, 2019
@TheWitness
Copy link
Member

I would rather see the error log of the syntax error. So, a callback to indicate that there was a problem with such and such a page is a better idea. Has to be a global link though, which is the bitch -1 realm.

@TheWitness
Copy link
Member

Then have an Admin Error Email based upon that Callback.

@TheWitness TheWitness modified the milestones: v1.3.0, v1.2.24 Oct 17, 2022
@TheWitness TheWitness changed the title AJAX handled errors do not disable plugins, if plugin is at fault AJAX handled errors do not notify Admins that page errors exist Oct 17, 2022
@TheWitness TheWitness modified the milestones: v1.2.24, v1.2.23 Oct 17, 2022
TheWitness added a commit that referenced this issue Oct 17, 2022
AJAX handled errors do not notify Admins that page errors exist
@TheWitness TheWitness added the resolved A fixed issue label Oct 17, 2022
@TheWitness
Copy link
Member

Turned this into a detection for 500 or better and will send an Administrative email and log a Cacti error when it occurs.

TheWitness added a commit that referenced this issue Oct 17, 2022
Slow the number of Emails if you have a page error to once every two hours per error page.
@netniV netniV changed the title AJAX handled errors do not notify Admins that page errors exist Notify Admins that page errors exist even when using dynamic callbacks Dec 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement plugins Plugin related issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants