Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Input Methods: Select unused field when adding new input fields #1422

Closed
netniV opened this issue Feb 28, 2018 · 3 comments
Closed

Data Input Methods: Select unused field when adding new input fields #1422

netniV opened this issue Feb 28, 2018 · 3 comments

Comments

@netniV
Copy link
Member

netniV commented Feb 28, 2018

When adding data input fields, the next unused field should be automatically selected to enable faster creation of fields. Additionally, using a previously selected field should present a warning since that field will be inserted twice and used in the "field order" making every field offset.

@netniV netniV changed the title Data Input: Select unused field when adding new input/output fields Graphs: Data Input: Select unused field when adding new input/output fields Mar 2, 2018
@netniV netniV changed the title Graphs: Data Input: Select unused field when adding new input/output fields Data Input Methods: Select unused field when adding new input/output fields Mar 2, 2018
@netniV netniV changed the title Data Input Methods: Select unused field when adding new input/output fields Data Input Methods: Select unused field when adding new input fields Mar 2, 2018
@netniV
Copy link
Member Author

netniV commented Mar 2, 2018

I have created a pull request for this so will now close the issue.

@netniV netniV closed this as completed Mar 2, 2018
@cigamit
Copy link
Member

cigamit commented Mar 3, 2018

Can you upload an animation of before and after behavior? Seeing is believing.

@netniV
Copy link
Member Author

netniV commented Mar 3, 2018

Before, it always selects the very first field. So, if you create a data input method, set it:

ss_method <first> <second> <third> <fourth>

You then go to add an input field, before the fix, will ALWAYS select <first> as the field.

This change detects that you've previously used <first>, so picks <second> as the default field you want to use. Same when you add the third, it realises that <first> and <second> have been used Which is logical, why would you use first again? If all fields have been used, it will always end up defaulting to if you try to add subsequent fields.

And don't forget that it uses the sequence order anyway, so I'm not sure you should be allowed to use a field more than once? That may be a further modification. As for an animation, I can do that next week but this doesn't take any functionality away only switches the default field used when creating a new input field

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants