Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When hovering over Plugin Install button, the message sometimes displays '<br />' #1437

Closed
netniV opened this issue Mar 3, 2018 · 12 comments
Labels
3rd Party Bug 3rd party bug

Comments

@netniV
Copy link
Member

netniV commented Mar 3, 2018

If you quickly move between plugin rows from and to a row that has the install icon, if the icon has dependancy errors, then sometimes the
tags are displayed rather than interpreted by the browser.

screen shot 2018-03-03 at 00 11 45

@cigamit
Copy link
Member

cigamit commented Mar 3, 2018

Oh, that is unfortunate.

@netniV
Copy link
Member Author

netniV commented Mar 3, 2018

This is how it looks when it's working properly. I think it's a timing issue somehow... but I can't for the life of me see why it would work one time and then not the other:

image

@cigamit cigamit added the unverified Some days we don't have a clue label Mar 4, 2018
@netniV
Copy link
Member Author

netniV commented Mar 4, 2018

Try this:

mar-04-2018 17-26-24

@cigamit
Copy link
Member

cigamit commented Mar 4, 2018

Seems like a jQueryUI issue. What it does it removes the title attribute during display, and then returns it to the prior setting once you hover off the element. So, must have something to do with jQueryUI.

@cigamit cigamit added 3rd Party Bug 3rd party bug and removed unverified Some days we don't have a clue labels Mar 4, 2018
@netniV
Copy link
Member Author

netniV commented Mar 4, 2018

Yeah I figured it's a timing issue, not quite sure why it would display the <br> sometimes and others it would be interpreted. It seem like it's escaping the characters like via htmlescape sometimes.

@cigamit
Copy link
Member

cigamit commented Mar 4, 2018

Yea, it's in jQueryUI. Another reason to update. Might be fixed there. Since you have a repeatable case, you might want to test using the latest.

@netniV
Copy link
Member Author

netniV commented Apr 5, 2018

I am wondering if I managed to get the HTML working when it shouldn't be given:
http://jqueryui.com/upgrade-guide/1.10/#tooltip

@cigamit
Copy link
Member

cigamit commented Apr 6, 2018

Review the jQueryUI page demonstrations. HTML is used in some of them. Check this example: http://jqueryui.com/tooltip/#custom-content

@netniV
Copy link
Member Author

netniV commented Apr 6, 2018

Yeah, that would suggest I'm not doing anything strange with the jQuery. It may be worth raising a bug report with them. I may do that this weekend if I figure out how.

@cigamit
Copy link
Member

cigamit commented Apr 7, 2018

See if you can reproduce in 1.12. If not, then it's likely already been resolved.

@cigamit
Copy link
Member

cigamit commented May 11, 2018

It's still broken in 1.12.

cigamit added a commit that referenced this issue May 11, 2018
Plugin install hover message sometimes shows line breaks rather than
formatted text
@cigamit
Copy link
Member

cigamit commented May 11, 2018

I resolved this in a semi grubby way, but it's fixed.

@cigamit cigamit closed this as completed May 11, 2018
@netniV netniV changed the title Plugin install hover message sometimes shows line breaks rather than formatted text When hovering over Plugin Install button, the message sometimes displays '<br />' Jan 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3rd Party Bug 3rd party bug
Projects
None yet
Development

No branches or pull requests

2 participants