Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fontawesome from 4.7 to 5.0.10 #1527

Closed
xmacan opened this issue Apr 10, 2018 · 4 comments
Closed

Update Fontawesome from 4.7 to 5.0.10 #1527

xmacan opened this issue Apr 10, 2018 · 4 comments
Labels
enhancement General tag for an enhancement

Comments

@xmacan
Copy link
Member

xmacan commented Apr 10, 2018

Is it possible to upgrade awesome font? New version has more than 300 new icons. I would like to use it in my plugins and in old version missing few icons.

Thank you

@netniV
Copy link
Member

netniV commented Apr 10, 2018

It could be done. It will need care though because FA changed from a single prefix of 'fa' to four prefixes in v5.0. Not an impossible job, but it would need a change in most pages. We can potentially get around it with their 'shim' for the time being but again that would need testing. I think that would be up to @ronytomen as to which milestone to aim for on that one.

You may be able to supply 5.0 in your own code, but you would be doubling on that library until the base catches up.

@cigamit
Copy link
Member

cigamit commented Apr 11, 2018

We need a license check as I know they were planning on making some changes in the 5.x release. Email is out for checking that. It's likely a nit as long as the classes are close. I've been waiting for this too. So, once we get approval, it should go quickly.

@cigamit
Copy link
Member

cigamit commented Apr 21, 2018

Looks like the license check went well. Does anyone want to take a crack at a pull request?

@cigamit cigamit added the enhancement General tag for an enhancement label Apr 21, 2018
@cigamit cigamit changed the title Update awesome fonts 4.7 -> 5.0 Update Fontawesome fonts 4.7 -> 5.0.10 Apr 22, 2018
@cigamit cigamit changed the title Update Fontawesome fonts 4.7 -> 5.0.10 Update Fontawesome from 4.7 to 5.0.10 Apr 22, 2018
cigamit added a commit that referenced this issue Apr 22, 2018
Update Fontawesome from 4.7 to 5.0.10
@cigamit
Copy link
Member

cigamit commented Apr 22, 2018

Wasn't too bad. Open a separate ticket if you find issues.

@cigamit cigamit closed this as completed Apr 22, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement
Projects
None yet
Development

No branches or pull requests

3 participants