Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Preview appends header=false too many times #1543

Closed
netniV opened this issue Apr 17, 2018 · 1 comment
Closed

Graph Preview appends header=false too many times #1543

netniV opened this issue Apr 17, 2018 · 1 comment

Comments

@netniV
Copy link
Member

netniV commented Apr 17, 2018

When you leave Graph Preview alone to refresh using the page timeout, it appends header=false repeatedly:

eg

graph_view.php?header=false&header=false&header=false

I'm not sure yet what the source of the issue is but I have a fix for this which is in the associated pull request. We should probably use the appendHeaderSuppress() to any javascript that is actively adding the parameter.

netniV added a commit to netniV/cacti that referenced this issue Apr 17, 2018
…y times

This fix corrects and issue with the setupPageRefresh() function where it appends header=false too many times as commented in Cacti#1543
cigamit pushed a commit that referenced this issue Apr 19, 2018
…es (#1544)

* Issue #1537: Numeric validation not ignoring blank elements

* Fix second instance of numeric_list issue

* Fix for Issue #1543 - Graph Preview appends header=false too many times

This fix corrects and issue with the setupPageRefresh() function where it appends header=false too many times as commented in #1543
@cigamit
Copy link
Member

cigamit commented Apr 20, 2018

Resolved.

@cigamit cigamit closed this as completed Apr 20, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants