Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escapeshellarg() sometimes causes warning to appear if null/empty value is passed in #1560

Closed
jagmeetbhinder opened this issue Apr 21, 2018 · 5 comments
Labels
bug Undesired behaviour

Comments

@jagmeetbhinder
Copy link

I am noticing below errors in the log file after upgrade.

2018/04/21 14:53:22 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler)(/lib/functions.php: 4628 cacti_debug_backtrace)

2018/04/21 14:53:22 - ERROR PHP ERROR: escapeshellarg(): Input string contains NULL bytes in file: /var/www/html/lib/functions.php on line: 3482

@cigamit
Copy link
Member

cigamit commented Apr 21, 2018

There should be more of a backtrace. Can you please upload the entirety of the backtrace?

@cigamit cigamit changed the title Upgrade From 1.1.36 to 1.1.38 Warning that escapeshellarg() is escaping a null Apr 21, 2018
cigamit added a commit that referenced this issue Apr 21, 2018
Warning that escapeshellarg() is escaping a null
@cigamit
Copy link
Member

cigamit commented Apr 21, 2018

I have resolved, but please do upload the backtrace.

@cigamit cigamit added the bug Undesired behaviour label Apr 21, 2018
@jagmeetbhinder
Copy link
Author

jagmeetbhinder commented Apr 22, 2018

These are the only two messages. Let me know if you want me to increase the logging level?

2018/04/21 14:46:30 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler)(/lib/functions.php: 4628 cacti_debug_backtrace)

2018/04/21 14:46:30 - ERROR PHP ERROR: escapeshellarg(): Input string contains NULL bytes in file: /var/www/html/lib/functions.php on line: 3482

@jagmeetbhinder
Copy link
Author

Validated...! this is fixed. Thanks for quick look into this issue.

@cigamit
Copy link
Member

cigamit commented Apr 22, 2018

No worries. Just going to close. Thanks!

@cigamit cigamit closed this as completed Apr 22, 2018
@netniV netniV changed the title Warning that escapeshellarg() is escaping a null escapeshellarg() sometimes causes warning to appear if null/empty value is passed in Dec 27, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour
Projects
None yet
Development

No branches or pull requests

2 participants