Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When installing, allow selection of theme on first screen #1584

Closed
netniV opened this issue Apr 28, 2018 · 2 comments
Closed

When installing, allow selection of theme on first screen #1584

netniV opened this issue Apr 28, 2018 · 2 comments
Labels
enhancement General tag for an enhancement installer Installation issue
Projects
Ajax-Based Installer

Comments

@netniV
Copy link
Member

netniV commented Apr 28, 2018

By allowing the user to pick which theme they want, we give the user the ability to see the styling of each theme from the start. This means that the installer should be reapplying the themes on change of selection.
@netniV netniV added this to To do in Ajax-Based Installer Apr 28, 2018
@cigamit
Copy link
Member

cigamit commented Apr 28, 2018

Nice!

@cigamit cigamit added installer Installation issue enhancement General tag for an enhancement help wanted Need help from community and removed help wanted Need help from community labels Apr 28, 2018
netniV added a commit to netniV/cacti that referenced this issue Apr 29, 2018
@netniV
Add theme default and fix false error report Cacti#1584
cc6705b
@netniV
Copy link
Member Author

netniV commented Apr 29, 2018

This is now in PR #1592

cigamit pushed a commit that referenced this issue Apr 30, 2018
@netniV @cigamit
Feature #1584 - Theme selection should be on first screen (#1592)
c74e27f 
* Add theme default and fix false error report #1584

* Switch sides for theme and acceptance

* Remove debug code
@netniV netniV closed this as completed Apr 30, 2018
Ajax-Based Installer automation moved this from To do to Done Apr 30, 2018
@netniV netniV changed the title Installer: Theme selection should be on first screen When installing, allow selection of theme on first screen Dec 31, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement General tag for an enhancement installer Installation issue
Projects
Ajax-Based Installer
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cigamit @netniV