Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installing, check that PHP can run and return an expected result #1588

Closed
netniV opened this issue Apr 28, 2018 · 1 comment
Closed
Assignees
Labels
enhancement General tag for an enhancement installer Installation issue

Comments

@netniV
Copy link
Member

netniV commented Apr 28, 2018

When checking the file paths, the PHP binary location should be run and expected output verified to make sure that PHP did actually run the test file. This will prevent issue with processes that are spawning in the background using the setting from failing.

@netniV netniV added this to To do in Ajax-Based Installer via automation Apr 28, 2018
@netniV netniV added enhancement General tag for an enhancement installer Installation issue labels Apr 29, 2018
@netniV netniV self-assigned this May 13, 2018
netniV added a commit to netniV/cacti that referenced this issue Jul 19, 2018
cigamit pushed a commit that referenced this issue Jul 21, 2018
* Feature #1588: Check that PHP can run a test file

* Feature #1628 - Allow the User to define a initial Network Discovery during Setup

* Fix QA issue with PHP 5.4

* Replace \n with PHP_EOL

* Minor changes to tabs vs. space and PHP_EOL

Will have to update packages based upon this too.

* Another minor pull where PHP_EOL was removed
@netniV
Copy link
Member Author

netniV commented Jul 21, 2018

This has now been merged.

@netniV netniV closed this as completed Jul 21, 2018
Ajax-Based Installer automation moved this from To do to Done Jul 21, 2018
@netniV netniV changed the title Installer: Check that PHP can run a test file When installing, check that PHP can run and return an expected result Dec 31, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement installer Installation issue
Projects
Development

No branches or pull requests

1 participant