Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Graph Template does not duplicate Data Query Graph Template Mappings #1671

Closed
TheNetworkIsDown opened this issue Jun 15, 2018 · 4 comments
Labels
enhancement General tag for an enhancement

Comments

@TheNetworkIsDown
Copy link
Contributor

How to reproduce:

  • Duplicate the "available disk space" template for example.
  • Goto a graph created using the original template and use "change graph template".
  • The previously duplicated and otherwise unchanged graph template cannot be selected even though it is identical. Only the original template is shown in the "New Graph Template" dropdown.
@cigamit
Copy link
Member

cigamit commented Jun 16, 2018

When changing the Graph Templates all the Data Source names must identical as must the count. If not, then it will not be permitted to be changed.

@cigamit cigamit added the question A question not a bug label Jun 16, 2018
@TheNetworkIsDown
Copy link
Contributor Author

TheNetworkIsDown commented Jun 16, 2018

So from my initial description would that be the case or not when trying to change to a template that was duplicated from the initial template and not modified?

image

(Where is "Available Disk Space(1)" in this case?)

image

@cigamit
Copy link
Member

cigamit commented Jun 17, 2018

Okay, I did an audit of the code and found that the duplication of the template does not duplicate any data query graph associations. This is why, for this data query, you don't see any other options. The step that was no replicated, and I'm thinking that is the real bug, is that when you duplicate the Graph Template (that is used in a Data Query), you should also duplicate the Data Query associations.

Near term, you should make those Data Query associations manually, and then you will be able to 'change graph template'. I did also find some minor issue that I will be making commit's for shortly, but this has no impact on your issue.

@cigamit cigamit added enhancement General tag for an enhancement and removed question A question not a bug labels Aug 7, 2018
@cigamit cigamit changed the title Change graph template not working Duplicate Graph Template does not duplicate Data Query Graph Template Mappings Aug 19, 2018
cigamit added a commit that referenced this issue Aug 19, 2018
Duplicate Graph Template does not duplicate Data Query Graph Template
Mappings
@cigamit
Copy link
Member

cigamit commented Aug 19, 2018

This issue is resolved now, but only for new Graph Templates that are duplicated.

@cigamit cigamit closed this as completed Aug 19, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants