Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When installing, report a warning if the default database collation is not utf8mb4_unicode_ci #1690

Closed
netniV opened this issue Jul 4, 2018 · 1 comment
Closed

When installing, report a warning if the default database collation is not utf8mb4_unicode_ci #1690

netniV opened this issue Jul 4, 2018 · 1 comment
Labels
enhancement General tag for an enhancement

Comments

@netniV
Copy link
Member

netniV commented Jul 4, 2018

The installer should present a big warning if the default database collation is wrong, not just if the tables are not utf8 compliant. The collation should be set to utf8_unicode_ci by default.
netniV added a commit to netniV/cacti that referenced this issue Jul 12, 2018
@netniV
Fixes for issues Cacti#1589 and 1690
5ef90ec 
This commit applies fixes for Cacti#1589 (Checking temporary folder is writable) and Cacti#1690 (Report a warning if collation is not utf8mb4_unicode_ci)
@netniV netniV mentioned this issue Jul 12, 2018
Merged
cigamit pushed a commit that referenced this issue Jul 14, 2018
@netniV @cigamit
Fixes for issues #1589 and #1690 (#1706)
94240ac 
* Fixes for issues #1589 and 1690

This commit applies fixes for #1589 (Checking temporary folder is writable) and #1690 (Report a warning if collation is not utf8mb4_unicode_ci)

* Remove debug code
@cigamit cigamit added the enhancement General tag for an enhancement label Jul 14, 2018
@netniV
Copy link
Member Author

netniV commented Jul 19, 2018

This has now been included.

@netniV netniV closed this as completed Jul 19, 2018
@netniV netniV changed the title Installer: Report a warning if default collation isn't utf8mb4_unicode_ci When installing, report a warning if the default database collation is not utf8mb4_unicode_ci Jan 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement General tag for an enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cigamit @netniV