Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Graph context menu to enable copy of graph image #1691

Closed
StoneCut opened this issue Jul 4, 2018 · 8 comments
Closed

Enhance Graph context menu to enable copy of graph image #1691

StoneCut opened this issue Jul 4, 2018 · 8 comments

Comments

@StoneCut
Copy link

StoneCut commented Jul 4, 2018

It would be great if there a way to enable some sort of "copy image to clipboard" function in the context menu for graphs. This would be useful for a rather laborious report I need to generate. Using "Graph" -> "Open in new tab" and then choosing copy image there is rather tedious.

Alternatively, it would be nice to be able to disable the context menu altogether so I can simply right-click on the image and use the browser's built-in functions for this. Sort of like the really old behaviour.

Thank you!

@netniV
Copy link
Member

netniV commented Jul 4, 2018

I think this could be added to the Graph context menu:
image

@StoneCut
Copy link
Author

StoneCut commented Jul 4, 2018

Yes, that would be great.

@netniV
Copy link
Member

netniV commented Jul 4, 2018

I've had a quick check as this would be similar to the copy to clipboard feature I implemented on the Device Verbose Query sections. One caveat seems to be that it would have to be copied as HTML so would not necessarily paste directly into an image editor in the same way the standard right click menu would.

@netniV
Copy link
Member

netniV commented Jul 4, 2018

Apparently MSPaint should handle it so I will give it a go and see what happens.

@StoneCut
Copy link
Author

StoneCut commented Jul 4, 2018

Sounds great but why would it be HTML? Isn‘t it possible to pplacd the static image that „open in new tab“ would display into clipboard? As you can tell I‘m not a coder so please forgive if this is a stupid question.

@netniV
Copy link
Member

netniV commented Jul 4, 2018

No, JavaScript is specifically limited in this fashion because it will only allow you to copy out of the document tree and whilst an image is an element, it's not a normal image in the browser sense.

netniV added a commit to netniV/cacti that referenced this issue Jul 8, 2018
This commit adds a 'Copy graph' option for feature Cacti#1691 to the context menu of graph images.
@netniV netniV changed the title Feature Request: "Copy image" in context menu Feature Request - Add a 'Copy graph' option to context menu of graphs Jul 8, 2018
cigamit pushed a commit that referenced this issue Jul 11, 2018
…1695)

* Feature #1691 - Add a 'Copy graph' option to context menu of graphs

This commit adds a 'Copy graph' option for feature #1691 to the context menu of graph images.

* Minor QA fix

* Minor QA fix
@netniV
Copy link
Member

netniV commented Jul 12, 2018

This is now in the development branch for 1.2

@netniV netniV closed this as completed Jul 12, 2018
@StoneCut
Copy link
Author

Many thanks for implementing this feature! Unfortunately I cannot use it for my report generation because I only get source code with a base64 encoded image in my Word report. The same goes for Outlook and OneNote.

@netniV netniV changed the title Feature Request - Add a 'Copy graph' option to context menu of graphs Enhance Graph context menu to enable copy of graph image Dec 31, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants