Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Validation reporting should have its own option #1692

Closed
netniV opened this issue Jul 4, 2018 · 1 comment
Closed

Input Validation reporting should have its own option #1692

netniV opened this issue Jul 4, 2018 · 1 comment
Labels
enhancement General tag for an enhancement

Comments

@netniV
Copy link
Member

netniV commented Jul 4, 2018

In order to properly test a system without having too much debugging information in the logs, I would recommend that the Input Validation routines use a separate logging option to allow a system running at a normal level to report uncheck input.

The function html_log_input_error() is called from get_request_var() but only if the 'developer' mode is turned on. I think a separate "log_validation_warnings" flag should be used instead.

netniV added a commit to netniV/cacti that referenced this issue Jul 8, 2018
This commit adds a separate option for feature Cacti#1692 to enable logging Input Validation issues even when developer mode is turned off
@cigamit cigamit added the enhancement General tag for an enhancement label Jul 14, 2018
@cigamit
Copy link
Member

cigamit commented Jul 21, 2018

The setting was already there, but we have now renamed it to be more clear as to it's purpose.

cigamit pushed a commit that referenced this issue Jul 21, 2018
…1696)

* Feature #1692 - Separate option for logging Input Validation issues

This commit adds a separate option for feature #1692 to enable logging Input Validation issues even when developer mode is turned off

* Finalise renaming of developer_mode to log_validation for cleaner understanding

* Remove log_validation from legacy location
@netniV netniV closed this as completed Jul 26, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants