Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide i18n for the graph right context menu #1703

Closed
cigamit opened this issue Jul 11, 2018 · 3 comments
Closed

Provide i18n for the graph right context menu #1703

cigamit opened this issue Jul 11, 2018 · 3 comments
Labels
bug Undesired behaviour

Comments

@cigamit
Copy link
Member

cigamit commented Jul 11, 2018

Right now the right click context menu for the graph copy, etc. menu has no internationalization available.

@cigamit cigamit added the bug Undesired behaviour label Jul 11, 2018
@netniV
Copy link
Member

netniV commented Jul 11, 2018

Yeah I noticed this was hardcoded into the jquery.zoom.js file. Since it's only required when that file is included, I think we could create an include function that would inject both the js and a localisation js with the text.

@cigamit
Copy link
Member Author

cigamit commented Jul 11, 2018

All JavaScript i18n is handled in include/global_session.php. Check it out. Simple change.

netniV added a commit to netniV/cacti that referenced this issue Jul 12, 2018
This commit adds i18n language facilities to the context menu displayed on graphs as per Cacti#1703.  It also adds a submenu icon to make it clearer that an entry has a submenu.
cigamit pushed a commit that referenced this issue Jul 14, 2018
This commit adds i18n language facilities to the context menu displayed on graphs as per #1703.  It also adds a submenu icon to make it clearer that an entry has a submenu.
@netniV
Copy link
Member

netniV commented Jul 14, 2018

This has now been merged:
screen shot 2018-07-14 at 18 09 56

@netniV netniV closed this as completed Jul 14, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour
Projects
None yet
Development

No branches or pull requests

2 participants