Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Realm should have a 'role' to help maintain changes between plugins #1990

Closed
netniV opened this issue Sep 28, 2018 · 4 comments
Closed
Labels
enhancement General tag for an enhancement plugins Plugin related issue resolved A fixed issue
Milestone

Comments

@netniV
Copy link
Member

netniV commented Sep 28, 2018

Table plugin_realms should have a new column added called role along with updating existing functions to be able to pass role. If no role is passed, assume 'common' as a default role (this enables backwards compatibility).

This will allow plugin owners to update their realms without creating duplicates as seen in Cacti/plugin_reportit#49

@cigamit
Copy link
Member

cigamit commented Sep 30, 2018

This way, we can group all realms instead of by plugin, by role. Current roles includes:

  • normal user,
  • template editor,
  • general administration,
  • system administration

@cigamit
Copy link
Member

cigamit commented Sep 30, 2018

It also makes it easier to update realms. Right now realm management for plugins is pretty much broken.

@cigamit cigamit added the enhancement General tag for an enhancement label Oct 9, 2018
@netniV netniV added this to the Cacti 1.3 milestone Oct 11, 2018
@netniV netniV added plugins Plugin related issue and removed plugins Plugin related issue labels Feb 21, 2019
@TheWitness TheWitness modified the milestones: v1.3.0, 1.2.11 Mar 19, 2020
@TheWitness
Copy link
Member

Moving this forward a bit to the 1.2.11 release. Plugins will have to adopt.

TheWitness added a commit that referenced this issue Mar 19, 2020
Plugin Realm should have a 'role' to help maintain changes between plugins
@TheWitness TheWitness added the resolved A fixed issue label Mar 19, 2020
@TheWitness
Copy link
Member

Fixed. Also responsive using flexi-grid layout.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement plugins Plugin related issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants