Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long snmp_indexes are being cut off #2133

Closed
rprofijt opened this issue Oct 30, 2018 · 10 comments
Closed

Long snmp_indexes are being cut off #2133

rprofijt opened this issue Oct 30, 2018 · 10 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@rprofijt
Copy link

rprofijt commented Oct 30, 2018

Seems like this was reported before in #864

After migration form 0.8x to 1.1.38 we had some long OID's that were being cut off in the snmp_index field, we have altered them in the host_snmp_cache now:

-  snmp_index varchar(191) NOT NULL default '',
+  snmp_index varchar(255) NOT NULL default '',

-  KEY snmp_index (snmp_index),
+  KEY snmp_index (snmp_index(191)),

I this is something likely to happen to other people. Probably caused by the fixes for the uft8mb4 compatibility.

@netniV
Copy link
Member

netniV commented Oct 30, 2018

It's actually down to a limitation on the amount of data that can be held in an index. The strange part is that you are allowing a larger value than you are indexing which can cause issues in itself from my knowledge.

@rprofijt
Copy link
Author

I don't know what you mean? In al the other tables the field is a varchar(255), but not in the host_snmp_cache. So that seems inconsistent.

@netniV
Copy link
Member

netniV commented Oct 31, 2018

Let us review this and come back to you as I hadn't looked at the other tables.

@cigamit
Copy link
Member

cigamit commented Nov 6, 2018

Yea, this one needs to be addressed. I know a few users who have this column at 1024 bytes. We need to fix prior to release.

@cigamit
Copy link
Member

cigamit commented Nov 6, 2018

@cigamit cigamit added bug Undesired behaviour beta Issue to be resolved in beta phase labels Nov 6, 2018
@cigamit cigamit added this to the Cacti 1.2 milestone Nov 6, 2018
@netniV
Copy link
Member

netniV commented Nov 6, 2018

Didn't we have an issue open for adding dynamic as part of the table conversion? Should the installer be looking for those that aren't?

@rprofijt
Copy link
Author

rprofijt commented Nov 9, 2018

@cigamit The only issue we had is that the size of the field was not 255, we are still using latin1.

@cigamit
Copy link
Member

cigamit commented Nov 10, 2018

Then, you should be safe. Since we are trying to be i18n compliant, these two settings are pretty important if you are in asia.

@cigamit
Copy link
Member

cigamit commented Nov 18, 2018

Moving this to 1.3 for now.

@cigamit cigamit modified the milestones: Cacti 1.2, Cacti 1.3 Nov 18, 2018
@cigamit cigamit removed the beta Issue to be resolved in beta phase label Nov 18, 2018
@cigamit cigamit modified the milestones: v1.3.0, v1.2.8 Nov 30, 2019
@cigamit cigamit changed the title 1.1.38: Long OID's are being cut off Long snmp_indexes are being cut off Nov 30, 2019
cigamit added a commit that referenced this issue Nov 30, 2019
Long snmp_indexes are being cut off
@cigamit cigamit added the resolved A fixed issue label Nov 30, 2019
@cigamit
Copy link
Member

cigamit commented Nov 30, 2019

This will be resolved in 1.2.8

@cigamit cigamit closed this as completed Nov 30, 2019
cigamit added a commit that referenced this issue Nov 30, 2019
Dynamic row format is mandatory for RHEL7/CentOS7
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants