Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When clicking on Graph Details from an Aggregate Graph Tree node, permission denied notice is shown #2259

Closed
DavidLiedke opened this issue Jan 3, 2019 · 18 comments
Assignees
Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue

Comments

@DavidLiedke
Copy link
Contributor

After the Update from 1.1.38 to 1.2.0 i have problems to see the following data from a Aggregate Graph:

  • Graph Details
  • Time Graph View
  • Display Graphs from this Aggregate

With version 1.1.38 all works fine.
Issue only appears with aggregate Graphs.

2019-01-03_11-11-09

@netniV
Copy link
Member

netniV commented Jan 3, 2019

I'll take a look. I don't recall a new permission being added for that but have you double checked your account permissions list?

@DavidLiedke
Copy link
Contributor Author

I'll take a look. I don't recall a new permission being added for that but have you double checked your account permissions list?

Yes i checked my permissions settings.

@DavidLiedke
Copy link
Contributor Author

I found a second bug in the web gui:
Checked with Firefox and Google Chrome
2019-01-03_12-25-16

@netniV
Copy link
Member

netniV commented Jan 3, 2019

OK, can you report that as a separate issue (may be related but more than likely a different one).

@netniV netniV changed the title Cacti 1.2.0 - Permission Denied --> Aggregate Graph When clicking on Graph Details from Tree node, permission denied notice is shown Jan 3, 2019
@netniV
Copy link
Member

netniV commented Jan 3, 2019

Are there any errors in your cacti log?

@DavidLiedke
Copy link
Contributor Author

Are there any errors in your cacti log?

No errors / warnings etc in the cacti log.

@netniV netniV self-assigned this Jan 3, 2019
@netniV netniV added bug Undesired behaviour gui UI related issue labels Jan 3, 2019
@netniV
Copy link
Member

netniV commented Jan 3, 2019

I can confirm that this appears to be an issue with Aggregate graphs but ordinary graphs are OK.

@netniV netniV changed the title When clicking on Graph Details from Tree node, permission denied notice is shown When clicking on Graph Details from an Aggregate Graph Tree node, permission denied notice is shown Jan 3, 2019
@netniV
Copy link
Member

netniV commented Jan 3, 2019

This appears to be because the code is looking for a template. Am I correct in assuming that your aggregate graph does not have a template? (mine didn't).

@DavidLiedke
Copy link
Contributor Author

2019-01-03_13-36-56

@netniV
Copy link
Member

netniV commented Jan 3, 2019

Can you run the following two SQL commands for me?

select * from aggregate_graphs where id = 843;
select * from aggregate_graph_templates;

@DavidLiedke
Copy link
Contributor Author

select * from aggregate_graphs where id = 843;

firefox_2019-01-03_14-10-19

Where do you get the id 843 ? Do you mean 840 ?

select * from aggregate_graph_templates;

firefox_2019-01-03_14-10-54

@netniV
Copy link
Member

netniV commented Jan 3, 2019

Yes I did. Sorry, it was my monitor and my bad eyesight :)

@DavidLiedke
Copy link
Contributor Author

firefox_2019-01-03_14-43-12

@cigamit
Copy link
Member

cigamit commented Jan 3, 2019

I think it might be better to get a db dump for analysis. Permissions seem to work on my system. It has to be some combination of security settings.

@DavidLiedke
Copy link
Contributor Author

Give me an mail adress and i will send you an dump of the database.

@netniV
Copy link
Member

netniV commented Jan 3, 2019

send it to developers@cacti.net so that we can both receive it.

netniV added a commit that referenced this issue Jan 3, 2019
When clicking on Graph Details from an Aggregate Graph Tree node, permission denied notice is shown.  This was due to the fact that no host is actually associated to an aggregate graph, thus the checks for h.deleted and h.disabled were failing as they were null not blank.
@netniV
Copy link
Member

netniV commented Jan 3, 2019

@DavidLiedke, I think I may have found the issue. Can you please get the latest lib/auth.php from the develop branch and try that out?

netniV added a commit that referenced this issue Jan 3, 2019
This applies a correction to the #2259 fix where the row count SQL is using a field that no longer exists.
@DavidLiedke
Copy link
Contributor Author

Perfect - with the latest lib/auth.php it works :) Thanks @netniV

@netniV netniV closed this as completed Jan 4, 2019
cigamit added a commit that referenced this issue Jan 4, 2019
netniV added a commit that referenced this issue Jan 4, 2019
When clicking on Graph Details from an Aggregate Graph Tree node, permission denied notice is shown.  This was due to the fact that no host is actually associated to an aggregate graph, thus the checks for h.deleted and h.disabled were failing as they were null not blank.
netniV added a commit that referenced this issue Jan 4, 2019
This applies a correction to the #2259 fix where the row count SQL is using a field that no longer exists.
@cigamit cigamit added the resolved A fixed issue label Jan 9, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants