Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When attempting to save Graph field, query_ifSpeed is not properly validated #2265

Closed
flippind opened this issue Jan 3, 2019 · 2 comments
Closed
Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue
Milestone

Comments

@flippind
Copy link

flippind commented Jan 3, 2019

I'm running into the same issue reported in this forum thread. Noticed the last hit on the thread suggests the bug report, but I'm unable to find existing. In my case, I am able to pull the expected value in the graph title via |query_ifSpeed| but am unable to populate that variable in either individual graphs nor graph template. Attempts to suggest via the associated Data Query Suggested Values -graphs (specifically upper-limit) has no discernible effect. It looks like this may have been resolved in the 0.8.8 release, but returned as early as 0.8.8b

   Total: 0.310000, Delta: 0.000000, Located input field 'ifSpeed' [walk]
   --
   Total: 0.350000, Delta: 0.040000, Executing SNMP walk for data @ '.1.3.6.1.2.1.2.2.1.5'
   Found item [ifSpeed='1000000000'] index: 1 [from value]
   Found item [ifSpeed='1000000000'] index: 2 [from value]
   Found item [ifSpeed='20000000'] index: 3 [from value]
   
   Cacti Version | 1.1.38
   Cacti OS | unix
   NET-SNMP Version | NET-SNMP version: 5.7.2
   RRDtool Version | RRDtool 1.4.x

In this image you can see the error thrown when using |query_ifSpeed| in the Graph Fields. Note that the graph title is successfully using |query_ifSpeed|.
1-3-2019 8-28-33 am

@cigamit cigamit added the enhancement General tag for an enhancement label Jan 4, 2019
@cigamit
Copy link
Member

cigamit commented Jan 4, 2019

Looks like a nice enhancement request.

@netniV netniV added this to the v1.3 milestone Mar 8, 2019
@TheWitness
Copy link
Member

Oh this is interesting, there is all sorts of code for this in the code, but you can not save in the template. Actually you can in the Graph Template "Graph Template Input" section, but that seems to be have been removed from the default template some releases ago. @gan-dalf had written this in almost a decade ago.

@TheWitness TheWitness added gui UI related issue bug Undesired behaviour and removed enhancement General tag for an enhancement labels Mar 17, 2020
@TheWitness TheWitness modified the milestones: v1.3.0, 1.2.11 Mar 22, 2020
TheWitness added a commit that referenced this issue Mar 22, 2020
Graph Field Limits Save Failed: Field Input Error - |query_ifSpeed|
@TheWitness TheWitness added the resolved A fixed issue label Mar 22, 2020
@netniV netniV changed the title Graph Field Limits Save Failed: Field Input Error - |query_ifSpeed| When attempting to save Graph field, query_ifSpeed is not properly validated Apr 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

4 participants