cacti.log show Duplicate entry for table 'snmpagent_cache'

[ddb4github]

cacti.log

2019/01/07  15:10:04 - CMDPHP SQL Backtrace:   (/poller.php[788]:snmpagent_poller_bottom(),  /lib/snmpagent.php[519]:MibCache->insert(),  /lib/mib_cache.php[211]:db_execute_prepared())
--
2019/01/07 15:10:04 - CMDPHP ERROR: A DB Exec Failed!, Error:  Duplicate entry '.1.3.6.1.4.1.23925.1.16.1.5.1' for key 'PRIMARY'

Suggest diff as:

--- lib/mib_cache.php        2018-11-26 13:59:58.000000000 +0800
+++ lib/mib_cache.php   2019-01-07 15:32:15.692192704 +0800
@@ -203,7 +203,7 @@
                                                $column_params['value'] = $values[$column_params['name']];
                                        }

-                                       db_execute_prepared('INSERT INTO `snmpagent_cache`
+                                       db_execute_prepared('INSERT IGNORE INTO `snmpagent_cache`
                                                (`oid`, `name`, `mib`, `type`, `otype`, `kind`, `max-access`, `value`)
                                                VALUES (?, ?, ?, ?, ?, ?, ?, ?)',
                                                array($column_params['oid'], $column_params['name'], $column_params['mib'],

[cigamit]

Pull requests are better. This one I would have rejected. It was that way previously, but the original author rejected the change, so it was reverted to what it is today. I have resolved using ON DUPLICATE KEY UPDATE instead.