Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database audit cli giving incorrect results #2281

Closed
dsclassen opened this issue Jan 7, 2019 · 2 comments
Closed

Database audit cli giving incorrect results #2281

dsclassen opened this issue Jan 7, 2019 · 2 comments
Assignees
Labels
bug Undesired behaviour resolved A fixed issue

Comments

@dsclassen
Copy link
Contributor

I've been troubleshooting various cacti problems lately and stumbled upon the audit_database.php script in the cli folder. I've been using it to manually diagnose and fix some of the problematic tables/rows in my cacti DB.

I was confused by the following errors:

Checking Table: 'data_source_stats_daily'               
ERROR Col: 'average', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'
ERROR Col: 'peak', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'

ERRORS: 2, WARNINGS: 0
---------------------------------------------------------------------------------------------
Checking Table: 'data_source_stats_hourly'              
ERROR Col: 'average', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'
ERROR Col: 'peak', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'

ERRORS: 2, WARNINGS: 0
---------------------------------------------------------------------------------------------
Checking Table: 'data_source_stats_hourly_cache'        
ERROR Col: 'value', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'

ERRORS: 1, WARNINGS: 0
---------------------------------------------------------------------------------------------
Checking Table: 'data_source_stats_hourly_last'         
ERROR Col: 'value', Attribute 'Type' invalid. Should be: 'double', Is: 'varchar(30)'
ERROR Col: 'value', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'
ERROR Col: 'calculated', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'

ERRORS: 3, WARNINGS: 0
---------------------------------------------------------------------------------------------
Checking Table: 'data_source_stats_monthly'             
ERROR Col: 'average', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'
ERROR Col: 'peak', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'

ERRORS: 2, WARNINGS: 0
---------------------------------------------------------------------------------------------
Checking Table: 'data_source_stats_weekly'              
ERROR Col: 'average', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'
ERROR Col: 'peak', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'

ERRORS: 2, WARNINGS: 0
---------------------------------------------------------------------------------------------
Checking Table: 'data_source_stats_yearly'              
ERROR Col: 'average', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'
ERROR Col: 'peak', Attribute 'Null' invalid. Should be: 'YES', Is: 'NO'

ERRORS: 2, WARNINGS: 0

several of these 'average' , 'peak' , and 'value' rows are specified as DOUBLE so why would the audit script suggest that the default value be 'YES' ?

@netniV
Copy link
Member

netniV commented Jan 7, 2019

If you are running 1.2.0, we forgot to update the audit_database.php script with the latest database information, therefore please do NOT use the repair option. Also, whilst most tables should be OK wait for 1.2.1 before testing it in earnest.

@cigamit cigamit self-assigned this Jan 8, 2019
@cigamit
Copy link
Member

cigamit commented Jan 9, 2019

Just as a side note, you should correct those issues.

@cigamit cigamit added the bug Undesired behaviour label Jan 9, 2019
@cigamit cigamit changed the title audit_databse.php unexpected error. Database audit cli giving incorrect results Jan 12, 2019
cigamit added a commit that referenced this issue Jan 12, 2019
Database audit cli giving incorrect results
@cigamit cigamit added the resolved A fixed issue label Jan 12, 2019
@cigamit cigamit closed this as completed Jan 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants