Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation wizard does not detect RRDtool version correctly #2282

Closed
BSOD2600 opened this issue Jan 7, 2019 · 6 comments
Closed

Installation wizard does not detect RRDtool version correctly #2282

BSOD2600 opened this issue Jan 7, 2019 · 6 comments
Assignees
Labels
bug Undesired behaviour installer Installation issue resolved A fixed issue
Milestone

Comments

@BSOD2600
Copy link
Contributor

BSOD2600 commented Jan 7, 2019

The rrdtool version detection used for the installation wizard is not correctly detecting/setting 1.7.0. however in the Technical Support page, the version detection is working. Yes, on Windows ;)

image

image

@BSOD2600 BSOD2600 added the installer Installation issue label Jan 7, 2019
@netniV netniV self-assigned this Jan 7, 2019
@cigamit
Copy link
Member

cigamit commented Jan 8, 2019

Interesting.

@cigamit cigamit changed the title [1.2.0] [Install Wizard] RRDTool version detection Install Wizard does not Detect RRDtool Version on Windows Mar 10, 2019
cigamit added a commit that referenced this issue Mar 10, 2019
Install Wizard does not Detect RRDtool Version on Windows
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Mar 10, 2019
@cigamit
Copy link
Member

cigamit commented Mar 10, 2019

Windows does not leverage standard error to standard output redirects. Problem solved.

@cigamit cigamit added this to the v1.2.3 milestone Mar 10, 2019
@netniV
Copy link
Member

netniV commented Mar 11, 2019

Actually, windows does use standard redirects so I'm confused why this is an issue. I am often using 2>&1 when running a command so I would recommend that we research this further.

https://support.microsoft.com/en-gb/help/110930/redirecting-error-messages-from-command-prompt-stderr-stdout

@netniV netniV modified the milestones: v1.2.3, v1.2.4 Mar 31, 2019
@cigamit cigamit closed this as completed Apr 25, 2019
@BSOD2600
Copy link
Contributor Author

This is still an issue with the latest 1.2.5 dev branch.

image

@BSOD2600 BSOD2600 reopened this Jul 10, 2019
@netniV
Copy link
Member

netniV commented Jul 10, 2019

I will try and get a windows environment setup tonight.

@netniV
Copy link
Member

netniV commented Jul 10, 2019

I have found the issue with this. The installer will always try and upgrade to the highest supported RRDTool version from now on regardless of what was previously defined in the settings. Also, ensured that all areas are using the same RRDTool version detection code rather than one using an array and another using the output value which may not be a valid setting any more.

Patch to follow.

@netniV netniV changed the title Install Wizard does not Detect RRDtool Version on Windows Installation wizard does not detect RRDtool version correctly Jul 10, 2019
@netniV netniV closed this as completed in 79ffee4 Jul 10, 2019
@netniV netniV modified the milestones: v1.2.4, v1.2.5 Jul 10, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour installer Installation issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants