Modifying plugin realm registration files and description not supported

[ddb4github]

Currently, api_plugin_register_realm only check 'file' and 'plugin' column. And 'file' column can be a file-list
Actually, most plugin frequently change file list, or change permission display with or without prefix "Plugin ->".
Then plugin Dev has to handle realm upgrade by self.

'monitor', 'monitor.php', 'View Monitoring Dashboard', 1);
'monitor', 'monitor.php', 'View Monitoring', 1);
'thold', 'notify_lists.php', 'Manage Notification Lists', 1);
'thold', 'notify_lists.php', 'Plugin -> Manage Notification Lists', 1);
'thold', 'thold.php', __('Configure Thresholds', 'thold'), 1);
'thold', 'thold_add.php,thold.php,listthold.php', 'Configure Thresholds', 1);
'flowview', 'flowview.php', 'Plugin -> Flow Viewer', 1);
'flowview', 'flowview.php,flowview_devices.php,flowview_schedules.php', 'Flow Viewer', 1);

So I prefer new diff as below to more flexible detect plugin realm existing. I'll create PR as soon:

--- lib/plugins.php
+++ lib/plugins.php
@@ -742,8 +742,8 @@
        $exists = db_fetch_cell_prepared('SELECT id
                FROM plugin_realms
                WHERE plugin = ?
-               AND file = ?',
-               array($plugin, $file));
+               AND (file LIKE ? OR display LIKE ?)',
+               array($plugin, "%$file%", "%$display%"));

        if ($exists === false) {
                db_execute_prepared('REPLACE INTO plugin_realms
@@ -777,10 +777,10 @@
                }
        } else {
                db_execute_prepared('UPDATE plugin_realms
-                       SET display = ?
+                       SET display = ?, file = ?
                        WHERE plugin = ?
-                       AND file = ?',
-                       array($display, $plugin, $file));
+                       AND id = ?',
+                       array($display, $file, $plugin, $exists));
        }
 }

[netniV]

Thanks for the PR but I think this functionality is a bad idea because it could easily match too many and select the wrong plugin. If there is a specific reason for this, I'm open to hearing it, but the change itself as it currently stands could end up giving replacing a different plugin.

[ddb4github]

Ha! the first condition is 'plugin name' in both of select and update clause.
So if there are some misleading, it is more about each plugin self. New code should not impact cross plugin

[netniV]

I believe that @cigamit has committed a change for this which is slightly different to your proposed request in b586e2f. Please check that out to see if resolves your issue and if so close this issue.