Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing Aggregate Graphs, orphaned items were not always removed #2365

Closed
cigamit opened this issue Jan 31, 2019 · 1 comment
Closed
Labels
aggregate Aggregate related issue bug Undesired behaviour

Comments

@cigamit
Copy link
Member

cigamit commented Jan 31, 2019

This problem will cause Data Sources, that you thinks should be removed, to linger. Additionally, you will have to delete the Aggregate and start over to resolve this issue.

@cigamit cigamit changed the title Graphs included in aggregate not that are removed are not managed properly Graphs included in aggregate that are removed are not managed properly Jan 31, 2019
@cigamit cigamit added bug Undesired behaviour aggregate Aggregate related issue labels Jan 31, 2019
cigamit added a commit that referenced this issue Jan 31, 2019
- Graphs included in aggregate that are removed are not managed properly
- The associate and disassociate functions were not following proper API
rules, they were leveraging request variables and redirecting using
header().
- Aggregate was not properly handling nth percentile.  It's now handling
that correctly, though still has an issue with the actual value.  This
will be fixed separately.
- Adding new convert to stacked line options for graph readability
- Totalling when using Print showing legend items was also showing graph
items, which is not correct.
- When totalling, Aggregate was attempting to show a blank line, but due
to an SQL format error, no blank line was displayed.
- Typo in one aggregate function was not properly handling the GPRINT
MIN graph item type
cigamit added a commit that referenced this issue Feb 2, 2019
This is a major bug fix to Aggregate.  Also found a bug in rrdtool that
we will have to work around.
The upside of the bug fix for #2365 is that it appears to have fixed
#599 and also an issue with legend alignment.  Legends should always
align nicely now.
@cigamit
Copy link
Member Author

cigamit commented Feb 2, 2019

Resolved now

@cigamit cigamit closed this as completed Feb 2, 2019
@netniV netniV changed the title Graphs included in aggregate that are removed are not managed properly When editing Aggregate Graphs, orphaned items were not always removed Feb 24, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aggregate Aggregate related issue bug Undesired behaviour
Projects
None yet
Development

No branches or pull requests

1 participant