Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reindexing a device, Graph Automation creates duplicate graphs every time #2393

Closed
vishnubraj opened this issue Feb 11, 2019 · 9 comments
Labels
bug Undesired behaviour resolved A fixed issue

Comments

@vishnubraj
Copy link

Describe the bug
Whenever i run the reindex script cacti automation rule create duplicate graphs... If i disable the rule it doesnt happen. Can you please check this.

screenshot 2019-02-11 at 3 59 59 pm

@hmorandell
Copy link
Contributor

hmorandell commented Feb 12, 2019

Hi,
I have a similar issue, but only with certain data query types. It seems not to happen with "SNMP - Interface Statistics", but it happens with a couple of my own created data query types
Maybe an error in my templates? Had not yet the time to check it, but it is somehow good to know that I'm not the only one to have such issues...

btw I'm running version 1.2.1

@cigamit
Copy link
Member

cigamit commented Feb 20, 2019

We need much more information, the rule screen shot would be a good start.

@cigamit cigamit added the unverified Some days we don't have a clue label Feb 20, 2019
@vishnubraj
Copy link
Author

Please find the rule screen shot

screenshot 2019-02-20 at 5 17 40 pm
screenshot 2019-02-20 at 5 18 20 pm

@cigamit
Copy link
Member

cigamit commented Feb 21, 2019

Well, that rule is so strait forward. No reason it should not be working.

@cigamit
Copy link
Member

cigamit commented Feb 21, 2019

Can you edit the data sources for each of those graphs and see if there is anything funny with the indexes?

@vishnubraj
Copy link
Author

Actually i dont see a data source created for this graph.. At the same time for some other graphs for the same template the data source created.. In Automation rules matching objects it still shows the graph has to be created..

screenshot 2019-02-21 at 5 50 39 pm

screenshot 2019-02-21 at 5 49 17 pm

@ian351c
Copy link

ian351c commented Feb 21, 2019

I am seeing the same thing as @vishnubraj in the built-in rule "Traffic 64 bit Server". I also have seen multiple graphs created for the interfaces on the items listed in the "matching objects" list. The duplicate graphs all refer to the same data sources for each device. (So multiple graphs for "eth0" on "Device A" all refer to the same RRD file when I look at the graphs in debug mode).

I'm not sure if this is definitive, but the devices where I'm seeing multiple graphs are devices that I added new data queries/data sources/graphs to AFTER adding the graphs for the interfaces (using 64 bit counters).

@cigamit
Copy link
Member

cigamit commented Feb 23, 2019

The duplication of the Data Sources should not happen. That is the expected behavior. However, we need to see what is going on with the creation of the second graph.

cigamit added a commit that referenced this issue Feb 23, 2019
Graph Automation creates duplicate graphs every time reindex the host
@cigamit
Copy link
Member

cigamit commented Feb 23, 2019

This is resolved now. Code was not re-written to handle the fact that Data Sources are no longer duplicated. It was looking at the Data Source and not the graph, so automation broke.

@cigamit cigamit added resolved A fixed issue bug Undesired behaviour and removed unverified Some days we don't have a clue labels Feb 23, 2019
@netniV netniV changed the title [1.2.0] Graph Automation creates duplicate graphs every time reindex the host When reindexing a device, Graph Automation creates duplicate graphs every time Feb 24, 2019
@cigamit cigamit closed this as completed Feb 24, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

4 participants