Make plugins non-case sensitive for folder names, whilst allowing nicer display names

[ddb4github]

Under https://github.com/Cacti/documentation/blob/develop/Plugin-Guidelines.md#plugin-data-entry
I do not find 'name' field definition. But most Cacti official plugin INFO file have 'name' field.

If 'name' field is valid(or valid in future), how about show "plugin name" as diff below if INFO.name is a specified format, e.g. ionCube

--- plugins.php   2019-01-26 12:40:13.000000000 +0800
+++ plugins.php   2019-02-19 17:21:10.542168108 +0800
@@ -217,7 +217,7 @@
                                                (directory, name, status, author, webpage, version, requires, infoname)
                                                VALUES (?, ?, ?, ?, ?, ?, ?, ?)",
                                                array(
-                                                       $file,
+                                                       (strtolower($file) == strtolower($cinfo[$file]['name']) ? $cinfo[$file]['name'] : $file),
                                                        $cinfo[$file]['longname'],
                                                        $cinfo[$file]['status'],
                                                        $cinfo[$file]['author'],

[netniV]

Because that would break directory checking functionality as it's the directory name that you are modifying there. The "name" should match the directory folder (and in most cases, this is in lower case).

[ddb4github]

Yes, above solution(diff) show "INFO defined name" only when lower(directory) equal with "lower(INFO.name)"

[netniV]

That is the SQL insert statement, though. Not just a display unless I'm missing something there.

[ddb4github]

Yes, you are correct. This page design to collect all plugin info into a tmp table, installed from 'plugin_config' table, non-installed from 'plugins' directory.
Then directly display plugin-list from that tmp table.

So need to modify more lines if I want to make sure INFO.name as display with some uppercase(not only first char, e.g. ionCube, SLES), and directory.name is only lowercase(ioncube, sles)

[netniV]

Yes, currently directory is case sensitive on Linux but not so on Windows.

[ddb4github]

So, to easily plugin usage and avoid plugin conflict(on linux), PIA should enforce plugin-developer to always keep directory name with lowercase.

Also for display, mixed upper/lower case can provide more readability than upfirst. But require more coding for each line about directory reading/comparing