Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree View becomes narrower and narrower when expanding/collapsing nodes with long names #2435

Closed
skyjou opened this issue Feb 20, 2019 · 14 comments
Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue
Milestone

Comments

@skyjou
Copy link
Contributor

skyjou commented Feb 20, 2019

Describe the bug
When the scroll bar shows, the tree column is narrower and narrower on each click.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Graphs'
  2. Click on 'Tree'

Expected behavior
Tree column should be the same width.

Screenshots
If the tree is enough long to let the scroll bar appear, then each click on tree cause column width of tree be narrower.
cacti_tree

Desktop

  • OS: Ubuntu 18.04
  • Browser: Chrome
  • Version: 72
@netniV
Copy link
Member

netniV commented Feb 21, 2019

I can confirm that this is a bug and does indeed happen only when the scroll bar shows. Once the scroll bar is removed, the width again stays static.

@netniV
Copy link
Member

netniV commented Feb 21, 2019

This occurs in:

  • Chrome

Does not occur in:

  • Firefox
  • Internet Explorer
  • Edge

@netniV netniV added bug Undesired behaviour gui UI related issue labels Feb 21, 2019
@netniV
Copy link
Member

netniV commented Feb 21, 2019

In fact, I can get weird things to happen depending on the size of one of the nodes that is appearing. If I collapse and expand nodes, sometimes a longer value will expand the width, others it will keep it at the same width but not long enough to read the whole text.

@cigamit cigamit added 3rd Party Bug 3rd party bug and removed bug Undesired behaviour labels Feb 24, 2019
@cigamit
Copy link
Member

cigamit commented Feb 24, 2019

Marking this as a Chrome bug as it only impacts Chrome right now.

@skyjou
Copy link
Contributor Author

skyjou commented Feb 24, 2019

No, this issue impacts Firefox and IE too. Do I need to upload the video?

@skyjou
Copy link
Contributor Author

skyjou commented Feb 24, 2019

Here is the Firefox video:
firefox

@netniV
Copy link
Member

netniV commented Feb 24, 2019

Interesting as I could not get this to replicate in IE/Firefox

@skyjou
Copy link
Contributor Author

skyjou commented Feb 24, 2019

My Firefox version is 65.0.1 (64-bit).

I can also reproduce it in IE11:

ie

@cigamit cigamit added this to the v1.2.3 milestone Feb 28, 2019
@cigamit cigamit added bug Undesired behaviour and removed 3rd Party Bug 3rd party bug labels Mar 10, 2019
@cigamit
Copy link
Member

cigamit commented Mar 15, 2019

I tested again last weekend on this and again, I'm unable to reproduce. Must be doing something wrong.

@skyjou
Copy link
Contributor Author

skyjou commented Mar 15, 2019

I just update Cacti to the latest development version, and I can still see the issue. It seems be more obvious in the Modern theme.

cigamit added a commit that referenced this issue Mar 16, 2019
* Issue encountered in modern theme "last device" is not visible in tree view in graphs
* Tree column is narrower and narrower on each click
* Plus a few additional minor visual issues
@cigamit cigamit added the resolved A fixed issue label Mar 16, 2019
@cigamit
Copy link
Member

cigamit commented Mar 16, 2019

This is resolved now.

@cigamit cigamit closed this as completed Mar 16, 2019
@skyjou
Copy link
Contributor Author

skyjou commented Mar 17, 2019

I pull the latest version from GitHub. I find it be wider and wider now.

chrome

@skyjou
Copy link
Contributor Author

skyjou commented Mar 17, 2019

In Paw theme, the tree work well now.

@netniV
Copy link
Member

netniV commented Mar 17, 2019

I don't know, you stop it shrinking and people moan, you just can't win (joking 👍 ). Will test this out tomorrow and see what each of the themes brings to the table.

@netniV netniV changed the title Tree column is narrower and narrower on each click Tree view list becomes narrower and narrower when expanding/collapsing nodes with long names Mar 30, 2019
@netniV netniV changed the title Tree view list becomes narrower and narrower when expanding/collapsing nodes with long names Tree View becomes narrower and narrower when expanding/collapsing nodes with long names Mar 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants