Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqltable_to_php.php does not export 'default' value of columns correctly #2460

Closed
cigamit opened this issue Feb 26, 2019 · 0 comments
Closed
Labels
beta Issue to be resolved in beta phase resolved A fixed issue
Milestone

Comments

@cigamit
Copy link
Member

cigamit commented Feb 26, 2019

Describe the bug
Several columns require the default of a varchar or char to be "" and not NULL. This is not enforced when outputting the PHP data.

To Reproduce
Export a table that includes a varchar() with a default of ""

  1. Review the column definition in the resulting array
  2. Note that there is no default

Expected behavior
A default value should be set.

cigamit added a commit that referenced this issue Feb 27, 2019
CLI script sqltable_to_php.php does not set proper default in its output
@netniV netniV changed the title CLI script sqltable_to_php.php does not set proper default in its output sqltable_to_php.php does not export 'default' value of columns correctly Feb 27, 2019
@cigamit cigamit added resolved A fixed issue beta Issue to be resolved in beta phase labels Feb 28, 2019
@cigamit cigamit added this to the v1.2.3 milestone Feb 28, 2019
@cigamit cigamit closed this as completed Mar 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta Issue to be resolved in beta phase resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant