Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to have a min or max value for RRDfile at zero '0' #2502

Closed
cigamit opened this issue Mar 10, 2019 · 0 comments
Closed

Unable to have a min or max value for RRDfile at zero '0' #2502

cigamit opened this issue Mar 10, 2019 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@cigamit
Copy link
Member

cigamit commented Mar 10, 2019

Describe the bug
Legacy Cacti behavior did not allow you to set a specific min or max value at zero. Cacti would always assume that '0' meant 'U' or no bounds. This breaks certain types of RRDfile enforcement to occur.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Data Templates
  2. Set the Max and Min values to '0'
  3. Create a Graph using the Data Soruce
  4. Review the RRDfile either by looking at the Data Source and using 'Data Source Debug' or rrdtool info and notice that the max and min values are 'U'

Expected behavior
We should be able to set a distinct '0' value for either 'min' or 'max'

Additional context
It's important to know that several legacy templates exist that will have these values set by default. We must ensure that if a legacy template is imported and it conforms to some of the old rules, we should detect and set the actual 'max' value to 'U' in some cases.

cigamit added a commit that referenced this issue Mar 10, 2019
Unable to have a min or max value for RRDfile at zero '0'
@cigamit cigamit added this to the v1.2.3 milestone Mar 10, 2019
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Mar 10, 2019
@cigamit cigamit closed this as completed Mar 10, 2019
cigamit added a commit that referenced this issue Mar 11, 2019
Need to use version compare
Unable to have a min or max value for RRDfile at zero '0'
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant