Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected errors when filtering Data Sources with invalid 'rows' value #2518

Closed
DavidLiedke opened this issue Mar 14, 2019 · 2 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@DavidLiedke
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Presets --> Data Profiles
  2. Choose one Profile
  3. Add / Edit one Data Source Profile RRAs
  4. Type letters instead of numbers in the "Rows" line

Expected behavior
(/data_source_profiles.php[57]:get_filter_request_var(),
/lib/html_utility.php[459]:die_html_input_error(),
/lib/html_validate.php[64]:cacti_debug_backtrace())

(/data_source_profiles.php[74]:get_size(), /data_source_profiles.php[720]:get_filter_request_var(),
/lib/html_utility.php[459]:die_html_input_error(),
/lib/html_validate.php[64]:cacti_debug_backtrace())

Cacti.log:

2019/03/14 09:04:36 - CMDPHP PHP ERROR WARNING Backtrace: (/data_source_profiles.php[67]:CactiErrorHandler())
2019/03/14 09:04:36 - ERROR PHP WARNING: A non-numeric value encountered in file: /srv/www/cacti/data_source_profiles.php on line: 67
2019/03/14 09:04:36 - CMDPHP PHP ERROR WARNING Backtrace: (/data_source_profiles.php[74]:get_size(), /data_source_profiles.php[722]:CactiErrorHandler())
2019/03/14 09:04:36 - ERROR PHP WARNING: A non-numeric value encountered in file: /srv/www/cacti/data_source_profiles.php on line: 722

Screenshots
2019-03-14_09-01-21

@netniV
Copy link
Member

netniV commented Mar 14, 2019

That shouldn't have made it past the request filtering in the first place as it's an invalid value for the filter. We will investigate that.

@netniV netniV added the bug Undesired behaviour label Mar 14, 2019
@cigamit
Copy link
Member

cigamit commented Mar 15, 2019

I've got this one.

cigamit added a commit that referenced this issue Mar 15, 2019
Data Source Profile RRAs - Type letters instead of numbers in the "Rows" line
@cigamit cigamit added the resolved A fixed issue label Mar 15, 2019
@cigamit cigamit changed the title [Cacti 1.2.2] Data Source Profile RRAs - Type letters instead of numbers in the "Rows" line Data Source Profile RRAs - Type letters instead of numbers in the "Rows" line Mar 15, 2019
@netniV netniV added this to the v1.2.3 milestone Mar 28, 2019
@netniV netniV changed the title Data Source Profile RRAs - Type letters instead of numbers in the "Rows" line Unexpected errors when filtering Data Sources with invalid 'rows' value Mar 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants