Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When checking MySQL configuration values, consider ON/OFF to be equal to 1/0 #2551

Closed
ddb4github opened this issue Mar 21, 2019 · 2 comments
Closed
Assignees
Labels
bug Undesired behaviour installer Installation issue resolved A fixed issue
Milestone

Comments

@ddb4github
Copy link
Contributor

On MySQL site:
Suggestion value should boolean value 'On'
https://dev.mysql.com/doc/refman/5.5/en/innodb-parameters.html#sysvar_innodb_large_prefix

image

@netniV
Copy link
Member

netniV commented Mar 21, 2019

I would agree with that.

@netniV
Copy link
Member

netniV commented Mar 21, 2019

In fact, we should probably allow that for each of the boolean checks.

@netniV netniV self-assigned this Mar 21, 2019
@netniV netniV added bug Undesired behaviour installer Installation issue labels Mar 21, 2019
@netniV netniV added this to the v1.2.3 milestone Mar 21, 2019
@netniV netniV changed the title Installer both 'on' and '1' should be valid value for 'innodb_large_prefix' When checking MySQL configuration values, consider ON/OFF to be equal to 1/0 Mar 21, 2019
@netniV netniV added the resolved A fixed issue label Mar 21, 2019
@netniV netniV closed this as completed in b8322d4 Mar 21, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour installer Installation issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants