Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using form_text_area(), invalid HTML can be generated #2623

Closed
ddb4github opened this issue Apr 8, 2019 · 1 comment
Closed

When using form_text_area(), invalid HTML can be generated #2623

ddb4github opened this issue Apr 8, 2019 · 1 comment
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.4

Comments

@ddb4github
Copy link
Contributor 

--- lib/html_form.php   2019-03-31 02:45:32.000000000 +0800
+++ lib/html_form.php  2019-04-08 21:03:31.370033168 +0800
@@ -1029,7 +1029,7 @@
                $placeholder = " placeholder='$placeholder'";
        }

-       print "<textarea class='$class ui-state-default ui-corner-all' aria-multiline='true' cols='$form_columns' rows='$form_rows' id='$form_name' name='$form_name'" . $class . $on_change . $placeholder . '>' . html_escape($form_previous_value) . "</textarea>\n";
+       print "<textarea class='$class ui-state-default ui-corner-all' aria-multiline='true' cols='$form_columns' rows='$form_rows' id='$form_name' name='$form_name'" . $on_change . $placeholder . '>' . html_escape($form_previous_value) . "</textarea>\n";
 }

 /* form_multi_dropdown - draws a standard html multiple select dropdown
cigamit added a commit that referenced this issue Apr 10, 2019
@cigamit
Resolving Issue #2623
4502664 
Invalid HTML when draw textarea: form_text_area
@cigamit
Copy link
Member

cigamit commented Apr 10, 2019

Good catch! Resolved.

@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Apr 10, 2019
@cigamit cigamit added this to the v1.2.4 milestone Apr 17, 2019
@cigamit cigamit closed this as completed Apr 25, 2019
@netniV netniV changed the title Invalid HTML when draw textarea: form_text_area When using form_text_area(), invalid HTML can be generated Apr 28, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.4
Development

No branches or pull requests
2 participants
@cigamit @ddb4github