Some filenames can be lost in log file selection list

[ddb4github]

array plus(+) operator will ignore some item with same key, even key is just serial no like 0, 1
So the first two file of $stdLogFileArray is always ignore.

--- lib/clog_webapi.php 2019-03-31 02:45:32.000000000 +0800
+++ lib/clog_webapi.php       2019-04-13 12:43:37.707854996 +0800
@@ -467,7 +467,8 @@
                                                arsort($stdLogFileArray, SORT_NATURAL);
                                                arsort($stdErrFileArray, SORT_NATURAL);

-                                               $logFileArray = $stdFileArray + $stdLogFileArray + $stdErrFileArray;
+                                               sort($stdLogFileArray);
+                                               $logFileArray = array_merge($stdFileArray, $stdLogFileArray, $stdErrFileArray);

                                                if (cacti_sizeof($logFileArray)) {
                                                        foreach ($logFileArray as $logFile) {

[netniV]

You are changing the sort order and losing the keys by using sort over arsort if I remember rightly (haven't double checked the functions on php.net)

[ddb4github]

--- cacti/lib/clog_webapi.php        2019-04-16 10:46:17.211593816 +0800
+++ cacti/lib/clog_webapi.php      2019-04-16 10:45:23.904577824 +0800
@@ -426,9 +426,14 @@
                                                                        continue;
                                                                }

+                                                               if(strpos($logFile, $stderrLogBase) === 0){
+                                                                       $stdErrFileArray[] = $logFile;
+                                                               } else {
                                                                $stdLogFileArray[] = $logFile;
                                                        }
+                                                       }

+                                                       $stdErrFileArray = array_unique($stdErrFileArray);
                                                        $stdLogFileArray = array_unique($stdLogFileArray);
                                                }

@@ -467,7 +472,7 @@
                                                arsort($stdLogFileArray, SORT_NATURAL);
                                                arsort($stdErrFileArray, SORT_NATURAL);

-                                               $logFileArray = $stdFileArray + $stdLogFileArray + $stdErrFileArray;
+                                               $logFileArray = array_merge($stdFileArray, $stdLogFileArray, $stdErrFileArray);

                                                if (cacti_sizeof($logFileArray)) {
                                                        foreach ($logFileArray as $logFile) {

[netniV]

OK, that seems to make more sense.

[cigamit]

This is resolved now.