Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation does not always calculate network range/subnet correctly #2661

Closed
lbullian opened this issue Apr 30, 2019 · 2 comments
Closed

Automation does not always calculate network range/subnet correctly #2661

lbullian opened this issue Apr 30, 2019 · 2 comments
Assignees
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@lbullian
Copy link

Describe the bug
The IP addresses calculated of hosts to be scanned in "Automation->Networks" are wrong when the input is something different from xx.xx.xx.0/xx.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Automation->Networks'
  2. Add new network for example '172.21.66.192/28'
  3. Discover Now, with debug mode.
  4. See logs. (Scanned: 172.21.66.192 to 172.21.66.205)

Expected behavior
Hosts scanned should be

  • HostMin: 172.21.66.193 10101100.00010101.01000010.1100 0001
  • HostMax: 172.21.66.206 10101100.00010101.01000010.1100 1110

Screenshots
not applicable

Desktop (please complete the following information):

  • OS: Linux Debian 9
  • Browser: Any
  • Version: Any

Additional context
The problem is not present when the network is something that ends in 0. Like: 172.20.84.0/28

@lbullian lbullian changed the title Automation network/netmask calculation Automation - Wrong network/netmask calculation Apr 30, 2019
@netniV netniV self-assigned this Apr 30, 2019
@netniV netniV added the bug Undesired behaviour label Apr 30, 2019
@cigamit
Copy link
Member

cigamit commented Jun 23, 2019

@netniV, should I take this one?

cigamit added a commit that referenced this issue Jun 23, 2019
* Automation - Wrong network/netmask calculation
* This should get a more comprehensive redesign at some point.
@cigamit cigamit added the resolved A fixed issue label Jun 23, 2019
@cigamit
Copy link
Member

cigamit commented Jun 23, 2019

This should be resolved in develop now. Thanks for pointing out. Some real old code there.

@cigamit cigamit added this to the v1.2.5 milestone Jun 24, 2019
@netniV netniV closed this as completed Jun 27, 2019
@netniV netniV changed the title Automation - Wrong network/netmask calculation Automation does not always calculate network range/subnet correctly Jul 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants