Increase length of Graph Item 'value' field to support pango-markup better

[frontierliu]

In case cacti 1.x support pango-markup text format, it is a good function to make cacti's graph text to have more color and other attributes.
But when I create a gprint_preset for input a pango-markup format string, eg. "<span foreground="blue" size="x-large">%8.2lf%s</span>", the text input box size limit to 40 chars, it is not enough for that pango-markup style string. I suggest increase the size limit to 100 chars, for better support pango-markup format string. 100 chars fit to the database gprint_preset table's field definition, no need to change database table. I found that text input box size limit was define in include/global_form.php, a minor modify shoud be ok.
Just a suggestion, thanks for the Cacti team's great work and I love it.

[netniV]

That does not sound like a massive increase but as it’s per field would lead to a longer maximum command line. Not sure if that is an issue more for Windows than Linux.

Unless one of the team can see a problem with it, I would suggest making that change in the 1.3 branch so it can be properly tested.

[TheWitness]

Turned out to be a simple thing. The database was already at 255 characters, so the only thing that needed to be changed was the form.

[netniV]

The issue was more with the length of the built up command line, not the database field. By increasing to 255 per field, it can greatly increase the likelihood that the command line can exceed its limits.

[frontierliu]

Yes, in a graph that have many datasource items, It is possible to exceed the limit of Windows system command line 8191 chars. I think cacti can make a enchancement : when someone click "Turn on Graph Debug Mode" , the command line display text also print the command line text total chars count, if the count exceed 8191 in a windows system, show some warning messages. like below:

That would be helpful.

[netniV]

Please create that as an enhancement request, I think it's not a bad plan. 👍

[TheWitness]

Yea, makes sense. The best plan is that if you are using Windows, you need to come to the light side and use a real operating system, on that is designed from the beginning for web hosting. I do like the idea of logging the command length (for windows users).

[frontierliu]

ok, I will create an enchancement request for it.