Skip to content

PHP memory should be unlimited in scripts that need more memory than the default #2712

@YongBoLiu

Description

@YongBoLiu

Describe the bug
A clear and concise description of what the bug is.

The hard code of set memory_limit need to be removed. The hard code make user can't change the memory limit value in /etc/php.ini. And lead to errors as below,

ERROR PHP ERROR: Allowed memory size of 536870912 bytes exhausted

To Reproduce
Steps to reproduce the behavior:

  1. Monitoring a large number of devices with more 354k graphs.
  2. Check the Clog.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
The hard code is not good solution, and make the value in /etc/php.ini not work. The lines of below, need to be removed.

[yboliu@oc8636837557 cacti]$ grep -R ini_set.*memory_limit . |grep -Ev plugin|grep -Ev '\-1'|grep -Ev read_config_option |grep memory_limit
./poller_commands.php:ini_set('memory_limit', '800M');
./install/cli_check.php:ini_set('memory_limit','256M');
./poller_spikekill.php:ini_set('memory_limit', '512M');
./include/vendor/phpsnmp/mib_parser.php:		ini_set('memory_limit', '256M');
./cmd.php:ini_set('memory_limit', '512M');
./poller.php:ini_set('memory_limit', '512M');
./lib/import.php:		ini_set('memory_limit', '384M');

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugUndesired behaviourresolvedA fixed issue

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions