Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse cursor should show as default pointer if column is not sortable #2735

Closed
ddb4github opened this issue Jun 13, 2019 · 1 comment
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ddb4github
Copy link
Contributor

Describe the bug
mouse cursor should be default if column is not sortable
Current mouse cursor always 'hand' for table column header

Suggestion Diff(example include modern them only)

--- include/themes/modern/main.css   2019-06-12 11:14:01.000000000 +0800
+++ include/themes/modern/main.css   2019-06-13 17:23:09.221388846 +0800
@@ -1583,7 +1583,7 @@
 }

 th.sortable {
-       cursor: pointer;
+       cursor: pointer !important;
 }

 th.primarySort, th.tablesorter-headerDesc, th.tablesorter-headerAsc {
@@ -1598,7 +1598,7 @@

 .tableHeader th, .tableHeader td {
        color: snow;
-       cursor: pointer;
+       cursor: default;
        vertical-align: middle;
        text-align: left;
        font-size: 11px;
@cigamit cigamit changed the title mouse cursor should be default if column is not sortable Mouse cursor should be default if column is not sortable Jun 22, 2019
cigamit added a commit that referenced this issue Jun 22, 2019
Mouse cursor should be default if column is not sortable
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Jun 22, 2019
@cigamit
Copy link
Member

cigamit commented Jun 22, 2019

Thanks @ddb4github, resolved.

@cigamit cigamit added this to the v1.2.5 milestone Jun 23, 2019
@netniV netniV changed the title Mouse cursor should be default if column is not sortable Mouse cursor should show as default pointer if column is not sortable Jul 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants